Move ThreadWrapper to ProcessThread in base.

webrtc/base/platform_thread_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#include "webrtc/system_wrappers/include/thread_wrapper.h"
+#include "webrtc/base/platform_thread.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webrtc/base/scoped_ptr.h"
 #include "webrtc/system_wrappers/include/sleep.h"
 
 namespace webrtc {
 
 // Function that does nothing, and reports success.
 bool NullRunFunction(void* obj) {
   SleepMs(0);  // Hand over timeslice, prevents busy looping.
   return true;
 }
 
-TEST(ThreadTest, StartStop) {
-  rtc::scoped_ptr<ThreadWrapper> thread = ThreadWrapper::CreateThread(
-      &NullRunFunction, nullptr, "ThreadTest");
+TEST(PlatformThreadTest, StartStop) {
+  rtc::scoped_ptr<PlatformThread> thread = PlatformThread::CreateThread(
+      &NullRunFunction, nullptr, "PlatformThreadTest");
   ASSERT_TRUE(thread->Start());
   EXPECT_TRUE(thread->Stop());
 }
 
 // Function that sets a boolean.
 bool SetFlagRunFunction(void* obj) {
   bool* obj_as_bool = static_cast<bool*>(obj);
   *obj_as_bool = true;
   SleepMs(0);  // Hand over timeslice, prevents busy looping.
   return true;
 }
 
-TEST(ThreadTest, RunFunctionIsCalled) {
+TEST(PlatformThreadTest, RunFunctionIsCalled) {
   bool flag = false;
-  rtc::scoped_ptr<ThreadWrapper> thread = ThreadWrapper::CreateThread(
+  rtc::scoped_ptr<PlatformThread> thread = PlatformThread::CreateThread(

[tommi, 2015/11/23 14:49:12]

do we need CreateThread() now that the implementation doesn't need to be
virtual?

[pbos-webrtc, 2015/11/23 15:05:40]

Nope, hence the TODO in the header. Preferring to do it separately.

       &SetFlagRunFunction, &flag, "RunFunctionIsCalled");
   ASSERT_TRUE(thread->Start());
 
   // At this point, the flag may be either true or false.
   EXPECT_TRUE(thread->Stop());
 
   // We expect the thread to have run at least once.
   EXPECT_TRUE(flag);
 }
 
+#if defined(WEBRTC_POSIX)
+TEST(PlatformThreadTestPosix, PrioritySettings) {

[tommi, 2015/11/23 14:49:12]

delete this test?

[pbos-webrtc, 2015/11/23 15:05:40]

Done.

+  // API assumes that max_prio - min_prio > 2. Test the extreme case.
+  const int kMinPrio = -1;
+  const int kMaxPrio = 2;
+
+  int last_priority = kMinPrio;
+  for (int priority = webrtc::kLowPriority;
+       priority <= webrtc::kRealtimePriority; ++priority) {
+    int system_priority = PlatformThread::ConvertToSystemPriority(
+        static_cast<webrtc::ThreadPriority>(priority), kMinPrio, kMaxPrio);
+    EXPECT_GT(system_priority, kMinPrio);
+    EXPECT_LT(system_priority, kMaxPrio);
+    EXPECT_GE(system_priority, last_priority);
+    last_priority = system_priority;
+  }
+}
+#endif  // defined(WEBRTC_POSIX)
 }  // namespace webrtc