Remove <iostream> include from file_audio_device.cc

Remove <iostream> include from file_audio_device.cc

Including this header in production code introduces static
initializers, which is disallowed in Chromium.

BUG=chromium:559766
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=henrika@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/fa8ae9a5356de3cb4fd820cc97d251c9a2ce000a

[kjellander_webrtc, 2015-11-23 08:42:29]

Description was changed from

==========
Remove iostream include from file_audio_device.cc

Including this header in production code introduces static
initializers, which is disallowed in Chromium.

BUG=chromium:559766
==========

to

==========
Remove <iostream> include from file_audio_device.cc

Including this header in production code introduces static
initializers, which is disallowed in Chromium.

BUG=chromium:559766
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-23 08:43:13]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[henrika_webrtc, 2015-11-23 09:06:29]

But the log lists:

# file_audio_device.cc webrtc::kPlayoutBufferSize
# file_audio_device.cc webrtc::kPlayoutNumChannels
# file_audio_device.cc webrtc::kRecordingBufferSize
# file_audio_device.cc webrtc::kRecordingNumChannels
# file_audio_device.cc webrtc::kPlayoutFixedSampleRate
# file_audio_device.cc webrtc::kRecordingFixedSampleRate
# file_audio_device.cc std::ios_base::Init::Init()@plt
# file_audio_device.cc std::__ioinit [#includes <iostream>, use <ostream>
instead]
# file_audio_device.cc __cxa_atexit@plt [registers a dtor to run at exit]
# file_audio_device.cc __init_array_end+0x32e0
# file_audio_device.cc __init_array_end+0x3b70

How can this change resolve all that?

[kjellander_webrtc, 2015-11-23 09:22:58]

On 2015/11/23 09:06:29, henrika_webrtc wrote:
> But the log lists:
> 
> # file_audio_device.cc webrtc::kPlayoutBufferSize
> # file_audio_device.cc webrtc::kPlayoutNumChannels
> # file_audio_device.cc webrtc::kRecordingBufferSize
> # file_audio_device.cc webrtc::kRecordingNumChannels
> # file_audio_device.cc webrtc::kPlayoutFixedSampleRate
> # file_audio_device.cc webrtc::kRecordingFixedSampleRate
> # file_audio_device.cc std::ios_base::Init::Init()@plt
> # file_audio_device.cc std::__ioinit [#includes <iostream>, use <ostream>
> instead]
> # file_audio_device.cc __cxa_atexit@plt [registers a dtor to run at exit]
> # file_audio_device.cc __init_array_end+0x32e0
> # file_audio_device.cc __init_array_end+0x3b70
> 
> How can this change resolve all that?

I'm not sure it resolves all but I did:

$ chromium/src/tools/linux/dump-static-initializers.py
out/Release/obj/webrtc/modules/audio_device/dummy/audio_device.file_audio_device.o

webrtc/modules/audio_device/dummy/file_audio_device.cc (initializer offset 0x0
size 0x7c)
  .L.str.3+0x5
  _GLOBAL__sub_I_file_audio_device.cc+0x10
  _GLOBAL__sub_I_file_audio_device.cc+0x17
  _GLOBAL__sub_I_file_audio_device.cc+0x1e
  _GLOBAL__sub_I_file_audio_device.cc+0x26
  _GLOBAL__sub_I_file_audio_device.cc+0x2d
  _GLOBAL__sub_I_file_audio_device.cc+0x48
  _GLOBAL__sub_I_file_audio_device.cc+0x50
  _GLOBAL__sub_I_file_audio_device.cc+0x57
  _GLOBAL__sub_I_file_audio_device.cc+0x72
  _GLOBAL__sub_I_file_audio_device.cc+0x7a
  _GLOBAL__sub_I_file_audio_device.cc+0x8
  webrtc::FileAudioDevice::InitPlayout()+0x16
  webrtc::FileAudioDevice::InitPlayout()+0x27
  webrtc::FileAudioDevice::InitPlayout()+0x2a
  webrtc::FileAudioDevice::StopPlayout()+0x49
  webrtc::FileAudioDevice::StopPlayout()+0x51
  webrtc::FileAudioDevice::StopPlayout()+0x74
  webrtc::FileAudioDevice::StartPlayout()+0x184
  webrtc::FileAudioDevice::StartPlayout()+0x1f
  webrtc::FileAudioDevice::StartPlayout()+0x51
  webrtc::FileAudioDevice::StartPlayout()+0x58
  webrtc::FileAudioDevice::StartPlayout()+0x8a
  webrtc::FileAudioDevice::InitRecording()+0x27
  webrtc::FileAudioDevice::InitRecording()+0x60
  webrtc::FileAudioDevice::InitRecording()+0x63
  webrtc::FileAudioDevice::RecThreadFunc(void*)+0x5
  webrtc::FileAudioDevice::StopRecording()+0x49
  webrtc::FileAudioDevice::StopRecording()+0x51
  webrtc::FileAudioDevice::StopRecording()+0x74
  webrtc::FileAudioDevice::StopRecording()+0x7c
  webrtc::FileAudioDevice::PlayThreadFunc(void*)+0x5
  webrtc::FileAudioDevice::StartRecording()+0x12
  webrtc::FileAudioDevice::StartRecording()+0x2a
  webrtc::FileAudioDevice::StartRecording()+0x2e
  webrtc::FileAudioDevice::StartRecording()+0x5f
  webrtc::FileAudioDevice::StartRecording()+0x66
  webrtc::FileAudioDevice::StartRecording()+0x6d
  webrtc::FileAudioDevice::StartRecording()+0x79
  webrtc::FileAudioDevice::StartRecording()+0xf6
  webrtc::FileAudioDevice::RecThreadProcess()+0x3c
  webrtc::FileAudioDevice::RecThreadProcess()+0x62
  webrtc::FileAudioDevice::RecThreadProcess()+0x7c
  webrtc::FileAudioDevice::RecThreadProcess()+0x80
  webrtc::FileAudioDevice::RecThreadProcess()+0x8d
  webrtc::FileAudioDevice::RecThreadProcess()+0xaf
  webrtc::FileAudioDevice::SetPlayoutDevice(unsigned short)+0x13
  webrtc::FileAudioDevice::PlayThreadProcess()+0x40
  webrtc::FileAudioDevice::PlayThreadProcess()+0xb1
  webrtc::FileAudioDevice::PlayThreadProcess()+0xde
  webrtc::FileAudioDevice::PlayoutDeviceName(unsigned short, char*, char*)+0x6b
  webrtc::FileAudioDevice::PlayoutDeviceName(unsigned short, char*, char*)+0x72
  webrtc::FileAudioDevice::PlayoutDeviceName(unsigned short, char*, char*)+0x7d
  webrtc::FileAudioDevice::PlayoutDeviceName(unsigned short, char*, char*)+0x7f
  webrtc::FileAudioDevice::PlayoutIsAvailable(bool&)+0xf
  webrtc::FileAudioDevice::SetRecordingDevice(unsigned short)+0xf
  webrtc::FileAudioDevice::RecordingDeviceName(unsigned short, char*,
char*)+0x6b
  webrtc::FileAudioDevice::RecordingDeviceName(unsigned short, char*,
char*)+0x72
  webrtc::FileAudioDevice::RecordingDeviceName(unsigned short, char*,
char*)+0x7d
  webrtc::FileAudioDevice::RecordingDeviceName(unsigned short, char*,
char*)+0x7f
  webrtc::FileAudioDevice::RecordingIsAvailable(bool&)+0xf
  webrtc::FileAudioDevice::FileAudioDevice(int, char const*, char const*)+0x19
  webrtc::FileAudioDevice::FileAudioDevice(int, char const*, char const*)+0x2c
  webrtc::FileAudioDevice::FileAudioDevice(int, char const*, char const*)+0x48
  webrtc::FileAudioDevice::FileAudioDevice(int, char const*, char const*)+0x54
  webrtc::FileAudioDevice::FileAudioDevice(int, char const*, char const*)+0x6f
  webrtc::FileAudioDevice::~FileAudioDevice()+0x9
  webrtc::FileAudioDevice::~FileAudioDevice()+0x3d
  webrtc::FileAudioDevice::~FileAudioDevice()+0x4f
  webrtc::FileAudioDevice::~FileAudioDevice()+0x7a
  webrtc::FileAudioDevice::~FileAudioDevice()+0xf

Found 71 static initializers in 1 files.

before the patch, and then again after:

$ chromium/src/tools/linux/dump-static-initializers.py
out/Release/obj/webrtc/modules/audio_device/dummy/audio_device.file_audio_device.o

Found 0 static initializers in 0 files.

I can check properly for the whole audio_device library of the GN build when I
get into the office.

[henrika_webrtc, 2015-11-23 09:32:58]

LGTM with minor comment

[henrika_webrtc, 2015-11-23 09:33:06]

https://codereview.webrtc.org/1468923002/diff/1/webrtc/modules/audio_device/d...
File webrtc/modules/audio_device/dummy/file_audio_device.cc (right):

https://codereview.webrtc.org/1468923002/diff/1/webrtc/modules/audio_device/d...
webrtc/modules/audio_device/dummy/file_audio_device.cc:16: int
kRecordingFixedSampleRate = 48000;
Could you also add const's here:

const int ...

[commit-bot: I haz the power, 2015-11-23 11:44:15]

Patchset 2 (id:??) landed as
https://crrev.com/fa8ae9a5356de3cb4fd820cc97d251c9a2ce000a
Cr-Commit-Position: refs/heads/master@{#10746}

[kjellander_webrtc, 2015-11-23 11:44:16]

Committed patchset #2 (id:20001) manually as
fa8ae9a5356de3cb4fd820cc97d251c9a2ce000a (presubmit successful).

[kjellander_webrtc, 2015-11-23 11:44:59]

Forgot to send comments before commit. Thanks.

https://codereview.webrtc.org/1468923002/diff/1/webrtc/modules/audio_device/d...
File webrtc/modules/audio_device/dummy/file_audio_device.cc (right):

https://codereview.webrtc.org/1468923002/diff/1/webrtc/modules/audio_device/d...
webrtc/modules/audio_device/dummy/file_audio_device.cc:16: int
kRecordingFixedSampleRate = 48000;
On 2015/11/23 09:33:06, henrika_webrtc wrote:
> Could you also add const's here:
> 
> const int ...

Sure thing. I did in PS#2.