Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1468313006:
Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) (Closed)
|
Created:
5 years ago by kjellander_webrtc Modified:
5 years ago CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision 68cf0b8..aa8e58a (361406:361601)
Due to Chromium moving over to building with a sysroot
image on Linux in
https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641627866b6869d
we need to disable that until http://crbug.com/561584 is fixed
(libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h).
Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a
Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a
No dependencies changed.
No update to Clang.
BUG=chromium:561584
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
NOTRY=True
NOPRESUBMIT=True
Committed: https://crrev.com/b86c5027a0ab701db21c052f0fd85d217eea9b57
Cr-Commit-Position: refs/heads/master@{#10795}
Patch Set 1 #Patch Set 2 : Set use_sysroot=0 until crbug.com/561584 is fixed #Messages
Total messages: 33 (18 generated)
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468313006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468313006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/11021)
Description was changed from ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. TBR= CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. TBR=tommi@webrtc.org BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ==========
kjellander@webrtc.org changed reviewers: + tommi@webrtc.org
Description was changed from ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. TBR=tommi@webrtc.org BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ==========
Description was changed from ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468313006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468313006/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468313006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468313006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1980)
pbos@webrtc.org changed reviewers: + pbos@webrtc.org
lgtm
Description was changed from ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal NOTRY=True ==========
On 2015/11/25 20:37:28, pbos-webrtc wrote: > lgtm win_baremetal breaks due to https://codereview.webrtc.org/1436553004/, which I have now reverted.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468313006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468313006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1985)
Description was changed from ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal NOTRY=True ========== to ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal NOTRY=True NOPRESUBMIT=True ==========
On 2015/11/25 20:45:55, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1985) Adding NOPRESUBMIT=True since I forgot about the special case for supplement.gypi where it needs to refer to files above it's own location. I haven't bothered doing an exception for that in PRESUBMIT.py.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468313006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468313006/20001
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal NOTRY=True NOPRESUBMIT=True ========== to ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal NOTRY=True NOPRESUBMIT=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal NOTRY=True NOPRESUBMIT=True ========== to ========== Roll chromium_revision 68cf0b8..aa8e58a (361406:361601) Due to Chromium moving over to building with a sysroot image on Linux in https://chromium.googlesource.com/chromium/src/+/a931efd5dc8d8783ce73a64fc641... we need to disable that until http://crbug.com/561584 is fixed (libudev.h is missing and is used by talk/media/devices/libudevsymboltable.h). Change log: https://chromium.googlesource.com/chromium/src/+log/68cf0b8..aa8e58a Full diff: https://chromium.googlesource.com/chromium/src/+/68cf0b8..aa8e58a No dependencies changed. No update to Clang. BUG=chromium:561584 CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/b86c5027a0ab701db21c052f0fd85d217eea9b57 Cr-Commit-Position: refs/heads/master@{#10795} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b86c5027a0ab701db21c052f0fd85d217eea9b57 Cr-Commit-Position: refs/heads/master@{#10795} |
