Chromium Code Reviews

Issue 1468183003: Improve documentation for ArrayView (Closed)

Created:
5 years ago by kwiberg-webrtc
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improve documentation for ArrayView Committed: https://crrev.com/c3ddb3e127a9821419671aef96f285a29d70781d Cr-Commit-Position: refs/heads/master@{#10775}

Patch Set 1 : #

Unified diffs Side-by-side diffs Stats (+52 lines, -5 lines)
M webrtc/base/array_view.h View 1 chunk +52 lines, -5 lines 0 comments

Messages

Total messages: 14 (7 generated)
kwiberg-webrtc
Seemed like a waste not to have the text I wrote for the announcement included ...
5 years ago (2015-11-24 11:47:52 UTC) #5
tommi
lgtm
5 years ago (2015-11-24 11:54:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468183003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468183003/60001
5 years ago (2015-11-24 11:54:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-11-24 13:55:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468183003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468183003/60001
5 years ago (2015-11-24 14:34:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years ago (2015-11-24 16:59:35 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-24 16:59:45 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3ddb3e127a9821419671aef96f285a29d70781d
Cr-Commit-Position: refs/heads/master@{#10775}

Powered by Google App Engine