Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1467243003: Remove ThreadWrapper::GetThreadId. The method just calls rtc::CurrentThreadId(), which also has a m… (Closed)

Created:
5 years, 1 month ago by tommi
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ThreadWrapper::GetThreadId. The method just calls rtc::CurrentThreadId(), which also has a more descriptive name. R=pbos@webrtc.org Committed: https://crrev.com/dfafd124186bcecfd1b3b18c24ce495972e4b50c Cr-Commit-Position: refs/heads/master@{#10753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -32 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M webrtc/system_wrappers/include/thread_wrapper.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/system_wrappers/source/thread_posix.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/system_wrappers/source/thread_win.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/system_wrappers/source/trace_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tommi
5 years, 1 month ago (2015-11-23 14:10:39 UTC) #1
pbos-webrtc
On 2015/11/23 14:10:39, tommi (webrtc) wrote: lgtm, ship it
5 years, 1 month ago (2015-11-23 14:12:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467243003/1
5 years, 1 month ago (2015-11-23 14:30:27 UTC) #6
tommi
Committed patchset #1 (id:1) manually as dfafd124186bcecfd1b3b18c24ce495972e4b50c (presubmit successful).
5 years, 1 month ago (2015-11-23 14:37:38 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 14:37:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfafd124186bcecfd1b3b18c24ce495972e4b50c
Cr-Commit-Position: refs/heads/master@{#10753}

Powered by Google App Engine
This is Rietveld 408576698