Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: PRESUBMIT.py

Issue 1467173006: Create webrtc/base/objc and move some logging code there (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add ARC flag Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | webrtc/base/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 long_lines_sources = lambda x: input_api.FilterSourceFile(x, 291 long_lines_sources = lambda x: input_api.FilterSourceFile(x,
292 black_list=(r'.+\.gyp$', r'.+\.gypi$', r'.+\.gn$', r'.+\.gni$', 'DEPS')) 292 black_list=(r'.+\.gyp$', r'.+\.gypi$', r'.+\.gn$', r'.+\.gni$', 'DEPS'))
293 results.extend(input_api.canned_checks.CheckLongLines( 293 results.extend(input_api.canned_checks.CheckLongLines(
294 input_api, output_api, maxlen=80, source_file_filter=long_lines_sources)) 294 input_api, output_api, maxlen=80, source_file_filter=long_lines_sources))
295 results.extend(input_api.canned_checks.CheckChangeHasNoTabs( 295 results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
296 input_api, output_api)) 296 input_api, output_api))
297 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( 297 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
298 input_api, output_api)) 298 input_api, output_api))
299 results.extend(input_api.canned_checks.CheckChangeTodoHasOwner( 299 results.extend(input_api.canned_checks.CheckChangeTodoHasOwner(
300 input_api, output_api)) 300 input_api, output_api))
301 results.extend(_CheckApprovedFilesLintClean(input_api, output_api)) 301 # Filter out files that are in objc or ios dirs from being cpplint-ed since
302 # they do not follow C++ lint rules.
303 black_list = input_api.DEFAULT_BLACK_LIST + (
304 r".*\bobjc[\\\/].*",
305 )
306 source_file_filter = lambda x: input_api.FilterSourceFile(x, None, black_list)
307 results.extend(_CheckApprovedFilesLintClean(
308 input_api, output_api, source_file_filter))
302 results.extend(_CheckNoIOStreamInHeaders(input_api, output_api)) 309 results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
303 results.extend(_CheckNoFRIEND_TEST(input_api, output_api)) 310 results.extend(_CheckNoFRIEND_TEST(input_api, output_api))
304 results.extend(_CheckGypChanges(input_api, output_api)) 311 results.extend(_CheckGypChanges(input_api, output_api))
305 results.extend(_CheckUnwantedDependencies(input_api, output_api)) 312 results.extend(_CheckUnwantedDependencies(input_api, output_api))
306 results.extend(_RunPythonTests(input_api, output_api)) 313 results.extend(_RunPythonTests(input_api, output_api))
307 return results 314 return results
308 315
309 316
310 def CheckChangeOnUpload(input_api, output_api): 317 def CheckChangeOnUpload(input_api, output_api):
311 results = [] 318 results = []
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 for builder in masters[master]: 356 for builder in masters[master]:
350 if 'presubmit' in builder: 357 if 'presubmit' in builder:
351 # Do not trigger presubmit builders, since they're likely to fail 358 # Do not trigger presubmit builders, since they're likely to fail
352 # (e.g. OWNERS checks before finished code review), and we're running 359 # (e.g. OWNERS checks before finished code review), and we're running
353 # local presubmit anyway. 360 # local presubmit anyway.
354 pass 361 pass
355 else: 362 else:
356 try_config[master][builder] = ['defaulttests'] 363 try_config[master][builder] = ['defaulttests']
357 364
358 return try_config 365 return try_config
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | webrtc/base/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698