Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1467173003: Remove duplicated headers after updating downstream code. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove duplicated headers after updating downstream code. Remove the headers that were kept to provide non-breaking updates of downstream code for https://codereview.webrtc.org/1418913006/ and https://codereview.webrtc.org/1417283007/. BUG=webrtc:5095 TESTED=Passing compile-trybots with --clobber flag: git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc NOTRY=True Committed: https://crrev.com/b7a88291dc9506165eba58975afc73b520daaf80 Cr-Commit-Position: refs/heads/master@{#10773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1242 lines) Patch
D webrtc/common_video/interface/i420_buffer_pool.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/common_video/interface/incoming_video_stream.h View 1 chunk +0 lines, -104 lines 0 comments Download
D webrtc/common_video/interface/video_frame_buffer.h View 1 chunk +0 lines, -159 lines 0 comments Download
D webrtc/common_video/interface/video_image.h View 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/modules/video_coding/main/interface/mock/mock_vcm_callbacks.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/modules/video_coding/main/interface/video_coding.h View 1 chunk +0 lines, -546 lines 0 comments Download
D webrtc/modules/video_coding/main/interface/video_coding_defines.h View 1 chunk +0 lines, -203 lines 0 comments Download
D webrtc/modules/video_coding/main/source/encoded_frame.h View 1 chunk +0 lines, -129 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
kjellander_webrtc
This can now be cleaned up!
5 years, 1 month ago (2015-11-23 18:39:45 UTC) #3
stefan-webrtc
lgtm
5 years ago (2015-11-24 14:11:01 UTC) #4
stefan-webrtc
On 2015/11/24 14:11:01, stefan-webrtc (holmer) wrote: > lgtm wait a minute, unlgtm, why deleting encoded_frame.h?
5 years ago (2015-11-24 14:11:48 UTC) #5
kjellander_webrtc
On 2015/11/24 14:11:48, stefan-webrtc (holmer) wrote: > On 2015/11/24 14:11:01, stefan-webrtc (holmer) wrote: > > ...
5 years ago (2015-11-24 14:18:21 UTC) #6
stefan-webrtc
right, thanks. lgtm
5 years ago (2015-11-24 14:23:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467173003/1
5 years ago (2015-11-24 15:12:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 15:13:51 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-24 15:13:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7a88291dc9506165eba58975afc73b520daaf80
Cr-Commit-Position: refs/heads/master@{#10773}

Powered by Google App Engine
This is Rietveld 408576698