Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1467163002: NetEq: Add new method last_output_sample_rate_hz (Closed)

Created:
5 years, 1 month ago by hlundin-webrtc
Modified:
5 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Add new method last_output_sample_rate_hz This change moves the logics for keeping track of the last ouput sample rate from AcmReceiver to NetEq, where it fits better. The getter function AcmReceiver::current_sample_rate_hz() is renamed to last_output_sample_rate_hz(). BUG=webrtc:3520 Committed: https://crrev.com/d89814bfd78b4c4ab6bf00e6ca4fd9e9ee6055c4 Cr-Commit-Position: refs/heads/master@{#10754}

Patch Set 1 #

Total comments: 5

Messages

Total messages: 7 (2 generated)
hlundin-webrtc
Karl, Please, take a look. https://codereview.webrtc.org/1467163002/diff/1/webrtc/modules/audio_coding/main/acm2/acm_receiver.cc File webrtc/modules/audio_coding/main/acm2/acm_receiver.cc (right): https://codereview.webrtc.org/1467163002/diff/1/webrtc/modules/audio_coding/main/acm2/acm_receiver.cc#newcode234 webrtc/modules/audio_coding/main/acm2/acm_receiver.cc:234: int samples_per_channel_int = resampler_.Resample10Msec( ...
5 years, 1 month ago (2015-11-23 11:54:33 UTC) #2
kwiberg-webrtc
lgtm https://codereview.webrtc.org/1467163002/diff/1/webrtc/modules/audio_coding/main/acm2/acm_receiver.cc File webrtc/modules/audio_coding/main/acm2/acm_receiver.cc (right): https://codereview.webrtc.org/1467163002/diff/1/webrtc/modules/audio_coding/main/acm2/acm_receiver.cc#newcode225 webrtc/modules/audio_coding/main/acm2/acm_receiver.cc:225: const int current_sample_rate_hz = neteq_->last_output_sample_rate_hz(); Excellent idea to ...
5 years, 1 month ago (2015-11-23 13:11:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467163002/1
5 years, 1 month ago (2015-11-23 13:22:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 14:49:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 14:49:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d89814bfd78b4c4ab6bf00e6ca4fd9e9ee6055c4
Cr-Commit-Position: refs/heads/master@{#10754}

Powered by Google App Engine
This is Rietveld 408576698