Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1466353003: Work around data race in TransmitMixer. (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Work around data race in TransmitMixer. BUG=chromium:389098 Committed: https://crrev.com/302c978c921c2c63e1ab2414f0db03d19d5bfc60 Cr-Commit-Position: refs/heads/master@{#10772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M webrtc/voice_engine/transmit_mixer.cc View 4 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
the sun
5 years ago (2015-11-24 10:43:53 UTC) #2
Henrik Grunell WebRTC
lgtm
5 years ago (2015-11-24 11:30:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466353003/1
5 years ago (2015-11-24 11:50:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-11-24 12:43:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466353003/1
5 years ago (2015-11-24 13:27:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 14:28:26 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 14:28:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/302c978c921c2c63e1ab2414f0db03d19d5bfc60
Cr-Commit-Position: refs/heads/master@{#10772}

Powered by Google App Engine
This is Rietveld 408576698