Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1466133002: Android SurfaceViewRenderer: Make sure not to call eglCreateSurface() twice (Closed)

Created:
3 years, 7 months ago by magjed_webrtc
Modified:
3 years, 6 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android SurfaceViewRenderer: Make sure not to call eglCreateSurface() twice eglCreateSurface() calls are posted to the render thread from both init() and surfaceCreated(). If the render thread does not process the eglCreateSurface() message from init() before surfaceCreated() is called, eglCreateSurface() will be called twice resulting in a crash. This CL makes sure eglCreateSurface() is only called once. BUG=b/25815604 R=hbos@webrtc.org Committed: https://crrev.com/4f2152e3286b03292836fd95813cc95933c79c4d Cr-Commit-Position: refs/heads/master@{#10769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
magjed_webrtc
hbos - Please take a look.
3 years, 6 months ago (2015-11-23 16:07:49 UTC) #3
hbos
lgtm
3 years, 6 months ago (2015-11-24 08:42:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466133002/1
3 years, 6 months ago (2015-11-24 12:00:29 UTC) #6
magjed_webrtc
Committed patchset #1 (id:1) manually as 4f2152e3286b03292836fd95813cc95933c79c4d (presubmit successful).
3 years, 6 months ago (2015-11-24 12:54:42 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2015-11-24 12:54:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f2152e3286b03292836fd95813cc95933c79c4d
Cr-Commit-Position: refs/heads/master@{#10769}

Powered by Google App Engine
This is Rietveld 408576698