Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1465163003: Add SurfaceTextureHelper.disconnect(Handler handler) method (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add SurfaceTextureHelper.disconnect(Handler handler) method This method should be used when the SurfaceTextureHelper is created to use a specific handler. This now guarantee that the looper used by handler is destroyed after a frame has been returned. Committed: https://crrev.com/9237559b16841c6a7762cfe015e83fb7dd3652e6 Cr-Commit-Position: refs/heads/master@{#10767}

Patch Set 1 #

Patch Set 2 : Fix.... #

Total comments: 2

Patch Set 3 : Addressed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java View 1 chunk +37 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/SurfaceTextureHelper.java View 1 2 4 chunks +19 lines, -4 lines 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
perkj_webrtc
And this one please?
5 years, 1 month ago (2015-11-23 20:14:57 UTC) #2
magjed_webrtc
Not the most obvious interface with the disconnect() and disconnect(Handler) function, but I guess it ...
5 years, 1 month ago (2015-11-23 20:36:03 UTC) #3
perkj_webrtc
No, maybe not that obvious. But a user now has two choices , both should ...
5 years, 1 month ago (2015-11-24 08:30:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465163003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465163003/40001
5 years, 1 month ago (2015-11-24 08:31:08 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-24 11:03:17 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 11:03:25 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9237559b16841c6a7762cfe015e83fb7dd3652e6
Cr-Commit-Position: refs/heads/master@{#10767}

Powered by Google App Engine
This is Rietveld 408576698