Fix memory leak in vcm_capturer.cc.

webrtc/test/vcm_capturer.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 16 matching lines @@
   char device_name[256];
   char unique_name[256];
   if (device_info->GetDeviceName(0, device_name, sizeof(device_name),
                                  unique_name, sizeof(unique_name)) !=
       0) {
     Destroy();
     return false;
   }
 
   vcm_ = webrtc::VideoCaptureFactory::Create(0, unique_name);
+  vcm_->AddRef();

[pbos-webrtc, 2015/11/26 17:12:12]

Shouldn't this be done inside ::Create() maybe? Creating it should imply that
you hold a reference to it.

+
   vcm_->RegisterCaptureDataCallback(*this);
 
   device_info->GetCapability(vcm_->CurrentDeviceName(), 0, capability_);
   delete device_info;
 
   capability_.width = static_cast<int32_t>(width);
   capability_.height = static_cast<int32_t>(height);
   capability_.maxFPS = static_cast<int32_t>(target_fps);
   capability_.rawType = kVideoI420;
 
@@ skipping 33 matching lines @@
 
 void VcmCapturer::Destroy() {
   if (vcm_ == NULL) {
     return;
   }
 
   vcm_->StopCapture();
   vcm_->DeRegisterCaptureDataCallback();
   vcm_->Release();
 
-  // TODO(pbos): How do I destroy the VideoCaptureModule? This still leaves
-  //             non-freed memory.
   vcm_ = NULL;
 }
 
 VcmCapturer::~VcmCapturer() { Destroy(); }
 
 void VcmCapturer::OnIncomingCapturedFrame(const int32_t id,
                                           const VideoFrame& frame) {
   rtc::CritScope lock(&crit_);
   if (started_)
     input_->IncomingCapturedFrame(frame);
 }
 
 void VcmCapturer::OnCaptureDelayChanged(const int32_t id, const int32_t delay) {
 }
 }  // test
 }  // webrtc