Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1464313004: Remove unused methods in VideoCodingModule. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused methods in VideoCodingModule. Also voids ::Codec which always passed. BUG= R=stefan@webrtc.org Committed: https://crrev.com/7776e782d6073b44f90a61da6a49d4b27ef7284a Cr-Commit-Position: refs/heads/master@{#11167}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -109 lines) Patch
M webrtc/modules/video_coding/include/video_coding.h View 1 3 chunks +1 line, -51 lines 0 comments Download
M webrtc/modules/video_coding/test/vcm_payload_sink_factory.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 2 chunks +1 line, -16 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_robustness_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_receiver_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pbos-webrtc
PTAL
5 years ago (2015-11-24 14:06:45 UTC) #1
stefan-webrtc
lgtm, but make sure this doesn't break other users of the API.
4 years, 11 months ago (2016-01-07 14:30:19 UTC) #2
pbos-webrtc
rebase
4 years, 11 months ago (2016-01-07 14:42:29 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7776e782d6073b44f90a61da6a49d4b27ef7284a Cr-Commit-Position: refs/heads/master@{#11167}
4 years, 11 months ago (2016-01-07 14:43:01 UTC) #6
pbos-webrtc
4 years, 11 months ago (2016-01-07 14:43:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7776e782d6073b44f90a61da6a49d4b27ef7284a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698