Issue 1462873003: iOS: Set enable_protobuf=1 by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1462873003: iOS: Set enable_protobuf=1 by default. (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc

Modified:
5 years, 1 month ago

Reviewers:
tkchin_webrtc

CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

iOS: Set enable_protobuf=1 by default. BUG=webrtc:5235 R=tkchin@webrtc.org Committed: https://crrev.com/5663b4fa9a62ec5e147b863e2ad632f45ab3670b Cr-Commit-Position: refs/heads/master@{#10724}

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	webrtc/build/common.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

kjellander_webrtc

You can ignore the iOS GN bots, they're not yet working.

5 years, 1 month ago (2015-11-19 16:53:22 UTC) #2

tkchin_webrtc

On 2015/11/19 16:53:22, kjellander (webrtc) wrote: > You can ignore the iOS GN bots, they're ...

5 years, 1 month ago (2015-11-19 19:15:55 UTC) #3

kjellander_webrtc

Committed patchset #1 (id:1) manually as 5663b4fa9a62ec5e147b863e2ad632f45ab3670b (presubmit successful).

5 years, 1 month ago (2015-11-20 08:37:56 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-11-20 08:37:57 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5663b4fa9a62ec5e147b863e2ad632f45ab3670b
Cr-Commit-Position: refs/heads/master@{#10724}