Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1462253002: Adding CreatePeerConnection method that uses new PC Initialize method. (Closed)

Created:
5 years, 1 month ago by Taylor Brandstetter
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding CreatePeerConnection method that uses new PC Initialize method. This will let us transition to the new Initialize method in Chromium, and then get rid of the old one. Committed: https://crrev.com/41b0798e1171a105404f6bc9dcb591cdc77d659f Cr-Commit-Position: refs/heads/master@{#10860}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Using std::move #

Patch Set 3 : Adding new method to PC factory proxy #

Patch Set 4 : Fixing Windows compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -12 lines) Patch
M talk/app/webrtc/peerconnectionfactory.h View 4 chunks +16 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 4 chunks +52 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactoryproxy.h View 1 2 3 chunks +23 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 2 3 3 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Taylor Brandstetter
This is just something I forgot to do in the "Set ICE servers" CL, where ...
5 years, 1 month ago (2015-11-20 00:16:35 UTC) #2
pthatcher1
lgtm https://codereview.webrtc.org/1462253002/diff/1/talk/app/webrtc/peerconnectionfactory.cc File talk/app/webrtc/peerconnectionfactory.cc (right): https://codereview.webrtc.org/1462253002/diff/1/talk/app/webrtc/peerconnectionfactory.cc#newcode314 talk/app/webrtc/peerconnectionfactory.cc:314: if (!pc->Initialize(configuration, constraints, allocator.Pass(), Apparently we can use ...
5 years, 1 month ago (2015-11-20 05:43:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462253002/60001
5 years ago (2015-12-01 19:18:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-01 20:16:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462253002/60001
5 years ago (2015-12-01 22:57:32 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-01 23:01:27 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 23:10:27 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/41b0798e1171a105404f6bc9dcb591cdc77d659f
Cr-Commit-Position: refs/heads/master@{#10860}

Powered by Google App Engine
This is Rietveld 408576698