Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1461903004: NetEq: Remove overly verbose logging (Closed)

Created:
5 years, 1 month ago by hlundin-webrtc
Modified:
5 years, 1 month ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Remove overly verbose logging This change removes all LS_VERBOSE logs that will print once every packet or more often. TBR=pbos@webrtc.org BUG=webrtc:5227 Committed: https://crrev.com/672304a654f6e774e90139f5a20add64a462f7c3 Cr-Commit-Position: refs/heads/master@{#10733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M webrtc/modules/audio_coding/neteq/decision_logic.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 8 chunks +0 lines, -40 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/timestamp_scaler.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461903004/1
5 years, 1 month ago (2015-11-20 16:00:43 UTC) #2
hlundin-webrtc
pbos: Please, review after the fact.
5 years, 1 month ago (2015-11-20 16:01:03 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-20 18:00:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461903004/1
5 years, 1 month ago (2015-11-20 18:40:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 19:57:08 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/672304a654f6e774e90139f5a20add64a462f7c3 Cr-Commit-Position: refs/heads/master@{#10733}
5 years, 1 month ago (2015-11-20 19:57:16 UTC) #9
pbos-webrtc
5 years, 1 month ago (2015-11-23 10:07:21 UTC) #10
Message was sent while issue was closed. 
lgtm, A++/10, would buy again

Powered by Google App Engine
This is Rietveld 408576698