rtcp::Nack packet moved into own file and got Parse function

rtcp::Nack packet moved into own file and got Parse function

Committed: https://crrev.com/a8890a57a5d03f942924ff61d3c62244f2bdab10
Cr-Commit-Position: refs/heads/master@{#11111}

[danilchap, 2015-11-18 14:32:53]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org, sprang@webrtc.org

[åsapersson, 2015-12-21 11:17:35]

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc (right):

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc:30: const uint16_t
kMinList[] = {0, 1, 3, 8, 16};
maybe kList?

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc:44: const size_t
kWrapPacketLength = sizeof(kWrapPacket);
remove

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc:62: Nack mparsed;
maybe parsed?

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h (right):

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h:22: // RFC4585, Section 6.1
Section 6.2?

[danilchap, 2015-12-21 15:55:55]

In addition to addressing comments changed tests to use gmock instead of
manually created mock.

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc (right):

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc:30: const uint16_t
kMinList[] = {0, 1, 3, 8, 16};
On 2015/12/21 11:17:35, åsapersson wrote:
> maybe kList?

Done.

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc:44: const size_t
kWrapPacketLength = sizeof(kWrapPacket);
On 2015/12/21 11:17:35, åsapersson wrote:
> remove

oops

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc:62: Nack mparsed;
On 2015/12/21 11:17:35, åsapersson wrote:
> maybe parsed?

Done.

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h (right):

https://codereview.webrtc.org/1461623003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h:22: // RFC4585, Section 6.1
On 2015/12/21 11:17:35, åsapersson wrote:
> Section 6.2?

Done.

[åsapersson, 2015-12-22 08:16:53]

lgtm

[danilchap, 2015-12-22 11:39:58]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-12-22 11:39:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1461623003/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2015-12-22 11:40:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461623003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461623003/60001

[commit-bot: I haz the power, 2015-12-22 11:43:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-22 11:43:15]

Description was changed from

==========
rtcp::Nack packet moved into own file and got Parse function
==========

to

==========
rtcp::Nack packet moved into own file and got Parse function

Committed: https://crrev.com/a8890a57a5d03f942924ff61d3c62244f2bdab10
Cr-Commit-Position: refs/heads/master@{#11111}
==========

[commit-bot: I haz the power, 2015-12-22 11:43:15]

Patchset 4 (id:??) landed as
https://crrev.com/a8890a57a5d03f942924ff61d3c62244f2bdab10
Cr-Commit-Position: refs/heads/master@{#11111}