Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1461513003: Temporarily disable VERIFY while bug is investigated. (Closed)

Created:
5 years, 1 month ago by phoglund
Modified:
5 years, 1 month ago
Reviewers:
AlexG, hbos, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Temporarily disable VERIFY while bug is investigated. This breaks some client apps in annoying ways, so disable for now. BUG=webrtc:4776 Committed: https://crrev.com/4dd7a653b5011495f4c805461bad33405c1fb1b8 Cr-Commit-Position: refs/heads/master@{#10693}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M talk/app/webrtc/videosource.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (5 generated)
phoglund
5 years, 1 month ago (2015-11-18 11:56:29 UTC) #2
perkj_webrtc
https://codereview.webrtc.org/1461513003/diff/1/talk/app/webrtc/videosource.cc File talk/app/webrtc/videosource.cc (right): https://codereview.webrtc.org/1461513003/diff/1/talk/app/webrtc/videosource.cc#newcode465 talk/app/webrtc/videosource.cc:465: // TODO(phoglund): Temporarily disabled VERIFY due to issue 4776. ...
5 years, 1 month ago (2015-11-18 15:12:20 UTC) #4
phoglund
I think I read a rule somewhere that you should not put TODOs on other ...
5 years, 1 month ago (2015-11-18 15:27:27 UTC) #5
hbos
While the verify check causes a crash in some client apps, I don't think we ...
5 years, 1 month ago (2015-11-18 15:29:14 UTC) #6
phoglund
On 2015/11/18 15:29:14, hbos wrote: > While the verify check causes a crash in some ...
5 years, 1 month ago (2015-11-18 15:42:50 UTC) #7
hbos
OK. lgtm
5 years, 1 month ago (2015-11-18 15:49:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461513003/20001
5 years, 1 month ago (2015-11-18 15:54:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1807)
5 years, 1 month ago (2015-11-18 15:58:26 UTC) #12
phoglund
Alex or Per: need owner stamp, feel free to land if lgty
5 years, 1 month ago (2015-11-18 16:59:19 UTC) #13
perkj_webrtc
On 2015/11/18 16:59:19, phoglund wrote: > Alex or Per: need owner stamp, feel free to ...
5 years, 1 month ago (2015-11-18 17:53:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461513003/20001
5 years, 1 month ago (2015-11-18 17:53:59 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 17:54:59 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 17:55:47 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4dd7a653b5011495f4c805461bad33405c1fb1b8
Cr-Commit-Position: refs/heads/master@{#10693}

Powered by Google App Engine
This is Rietveld 408576698