Using Rent-A-Codec for static Codec access in WVoE/MC.

Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVoiceEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h (lines 460-470).

BUG=webrtc:4690
Committed: https://crrev.com/26c8c91de2db5da06ff337aae48e1d725aa91ab7
Cr-Commit-Position: refs/heads/master@{#10819}

[the sun, 2015-11-23 11:37:15]

Description was changed from

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

BUG=webrtc:4690
==========

to

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

BUG=webrtc:4690
==========

[the sun, 2015-11-26 13:07:40]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[the sun, 2015-11-26 13:17:30]

Description was changed from

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

BUG=webrtc:4690
==========

to

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVideoEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the
CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into
WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h
(lines 460-470).

BUG=webrtc:4690
==========

[the sun, 2015-11-26 13:17:47]

Description was changed from

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVideoEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the
CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into
WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h
(lines 460-470).

BUG=webrtc:4690
==========

to

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVoiceEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the
CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into
WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h
(lines 460-470).

BUG=webrtc:4690
==========

[kwiberg-webrtc, 2015-11-26 14:13:56]

lgtm

https://codereview.webrtc.org/1461333002/diff/60001/talk/media/webrtc/fakeweb...
File talk/media/webrtc/fakewebrtcvoiceengine.h (right):

https://codereview.webrtc.org/1461333002/diff/60001/talk/media/webrtc/fakeweb...
talk/media/webrtc/fakewebrtcvoiceengine.h:320: ch->recv_codecs.push_back(c);
auto db = webrtc::acm2::RentACodec::Database();
ch->recv_codecs.insert(ch->recv_codecs.end(), db.begin(), db.end());

or, if the vector is sure to be empty,

ch->recv_codecs.assign(db.begin(), db.end());

[the sun, 2015-11-26 14:27:20]

https://codereview.webrtc.org/1461333002/diff/60001/talk/media/webrtc/fakeweb...
File talk/media/webrtc/fakewebrtcvoiceengine.h (right):

https://codereview.webrtc.org/1461333002/diff/60001/talk/media/webrtc/fakeweb...
talk/media/webrtc/fakewebrtcvoiceengine.h:320: ch->recv_codecs.push_back(c);
On 2015/11/26 14:13:56, kwiberg-webrtc wrote:
> auto db = webrtc::acm2::RentACodec::Database();
> ch->recv_codecs.insert(ch->recv_codecs.end(), db.begin(), db.end());
> 
> or, if the vector is sure to be empty,
> 
> ch->recv_codecs.assign(db.begin(), db.end());

Done.

[the sun, 2015-11-26 14:27:25]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-11-26 14:27:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1461333002/#ps80001 (title:
"rebase+comment")

[commit-bot: I haz the power, 2015-11-26 14:27:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461333002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461333002/80001

[commit-bot: I haz the power, 2015-11-26 16:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 16:27:55]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-11-26 18:05:49]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-11-26 18:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461333002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461333002/80001

[commit-bot: I haz the power, 2015-11-26 20:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 20:06:22]

Exceeded global retry quota

[the sun, 2015-11-27 09:00:48]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-11-27 09:00:48]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1461333002/#ps100001 (title:
"rebase")

[commit-bot: I haz the power, 2015-11-27 09:00:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461333002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461333002/100001

[commit-bot: I haz the power, 2015-11-27 12:00:29]

Description was changed from

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVoiceEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the
CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into
WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h
(lines 460-470).

BUG=webrtc:4690
==========

to

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVoiceEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the
CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into
WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h
(lines 460-470).

BUG=webrtc:4690
==========

[commit-bot: I haz the power, 2015-11-27 12:00:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-27 12:00:35]

Description was changed from

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVoiceEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the
CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into
WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h
(lines 460-470).

BUG=webrtc:4690
==========

to

==========
Using Rent-A-Codec for static Codec access in WVoE/MC.

Mostly moved code around in WebRtcVoiceEngine:
- Added new internal class WebRtcVoiceCodecs for static codec functions and the
CodecPrefs.
- ConstructCodecs() -> WebRtcVoiceCodecs::SupportedCodecs().
- FindWebRtcCodec -> WebRtcVoiceCodecs::ToCodecInst().
- WebRtcVoiceMediaChannel::SetRecvCodecsInternal() folded into
WebRtcVoiceMediaChannel::SetRecvCodecs() (slight logic change).
- Change to how SetRecPayloadType() is implemented in fakewebrtcvoiceengine.h
(lines 460-470).

BUG=webrtc:4690

Committed: https://crrev.com/26c8c91de2db5da06ff337aae48e1d725aa91ab7
Cr-Commit-Position: refs/heads/master@{#10819}
==========

[commit-bot: I haz the power, 2015-11-27 12:00:36]

Patchset 6 (id:??) landed as
https://crrev.com/26c8c91de2db5da06ff337aae48e1d725aa91ab7
Cr-Commit-Position: refs/heads/master@{#10819}