Use EGL14 if supported on Android

This cl change so that we use EGL14 where it is supported and EGL10 otherwise. The idea is to make this agnostic to an application and for WebRTC except in EGLBase.

The reason we want to use EGL14 is to be able to use EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
TBR=glaznew@webrtc.org

Committed: https://crrev.com/40455d6f37fda78ea069a51d95f28994bd736864
Cr-Commit-Position: refs/heads/master@{#10864}

[perkj_webrtc, 2015-11-20 13:50:23]

Description was changed from

==========
Hide Egl version within EglBase.

WIP
==========

to

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when witing textures to MediaEncoder.

BUG=webrtc:4993
==========

[perkj_webrtc, 2015-11-20 13:50:32]

Description was changed from

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when witing textures to MediaEncoder.

BUG=webrtc:4993
==========

to

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
==========

[perkj_webrtc, 2015-11-20 13:51:21]

perkj@webrtc.org changed reviewers:
+ magjed@webrtc.org

[perkj_webrtc, 2015-11-20 13:51:22]

please?

[magjed_webrtc, 2015-11-20 17:05:30]

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right):

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:38: final EglBaseInterface
eglDelegate;
This is an unnecessary indirection. Return the interface directly instead from
the factory methods.

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:53: public static interface
EglContext {
Rename to just Context since this is now a nested class. I.e. EglBase.Context is
the interface, and EglBase10.Context/EglBase14.Context are the implementations.

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:94: public
EglBase(EglContext sharedContext, ConfigType configType) {
Remove |eglDelegate| and make the EglBase ctors static factory methods instead
that returns an implementation of the interface. E.g.
public EglBaseInterface create(Context sharedContext, ConfigType configType) {
  return (sharedContext == null || sharedContext instanceof EglBase14.Context)
    ? new EglBase14((EglBase14.Context) sharedContext, configType)
    : new EglBase10((EglBase10.Context) sharedContext, configType);
}

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:109: public void
createSurface(SurfaceTexture surfaceTexture) {
Remove all these unnecessary delegation functions.

[perkj_webrtc, 2015-11-23 14:55:56]

PTAL

This cl does not break AppRTC and should not break other apps either. 
When all apps has been updated, I would like to remove EglBase.

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right):

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:38: final EglBaseInterface
eglDelegate;
On 2015/11/20 17:05:29, magjed_webrtc wrote:
> This is an unnecessary indirection. Return the interface directly instead from
> the factory methods.

Done.

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:53: public static interface
EglContext {
On 2015/11/20 17:05:29, magjed_webrtc wrote:
> Rename to just Context since this is now a nested class. I.e. EglBase.Context
is
> the interface, and EglBase10.Context/EglBase14.Context are the
implementations.

Done.

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:94: public
EglBase(EglContext sharedContext, ConfigType configType) {
On 2015/11/20 17:05:29, magjed_webrtc wrote:
> Remove |eglDelegate| and make the EglBase ctors static factory methods instead
> that returns an implementation of the interface. E.g.
> public EglBaseInterface create(Context sharedContext, ConfigType configType) {
>   return (sharedContext == null || sharedContext instanceof EglBase14.Context)
>     ? new EglBase14((EglBase14.Context) sharedContext, configType)
>     : new EglBase10((EglBase10.Context) sharedContext, configType);
> }

Done.

https://codereview.webrtc.org/1461083002/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:109: public void
createSurface(SurfaceTexture surfaceTexture) {
On 2015/11/20 17:05:29, magjed_webrtc wrote:
> Remove all these unnecessary delegation functions.

Done.

[magjed_webrtc, 2015-11-25 10:53:19]

https://codereview.webrtc.org/1461083002/diff/100001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/Egl.java (right):

https://codereview.webrtc.org/1461083002/diff/100001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/Egl.java:58: return (sharedContext ==
null && EglBase14.isEGL14Supported()
This is correct precedence, but we typically have parenthesis to group && and
||, no? You can also write it with just two tests:
sharedContext instanceof EglBase10.Egl10Context || !EglBase14.isEGL14Supported()
? egl10 : egl14.

https://codereview.webrtc.org/1461083002/diff/100001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/EglBase10.java (right):

https://codereview.webrtc.org/1461083002/diff/100001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/EglBase10.java:66: public static class
Egl10Context implements Context {
I prefer just Context as name (if it's possible).

[perkj_webrtc, 2015-11-25 14:23:03]

PTAL

[perkj_webrtc, 2015-11-25 14:23:03]

PTAL

[magjed_webrtc, 2015-11-26 09:54:48]

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right):

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:47: * Holds EGL state and
utility methods for handling an EGL10 EGLContext, an EGLDisplay,
nit: Add ',' between EGL10 and EGLContext.

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:267: public static class P
extends Context {
What is this?

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/EglBase14.java (right):

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/EglBase14.java:77: super(true);
true /* dummy */

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:233:
CameraEventsHandler eventsHandler, EglBase.Context sharedEglContext) {
Will this change not break external apps? Maybe keep the old create() and just
wrap the EGLContext and call this create() instead/

[perkj_webrtc, 2015-11-26 10:05:21]

please

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/EglBase.java (right):

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:47: * Holds EGL state and
utility methods for handling an EGL10 EGLContext, an EGLDisplay,
On 2015/11/26 09:54:48, magjed_webrtc wrote:
> nit: Add ',' between EGL10 and EGLContext.

this refer to egl 1.0

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/EglBase.java:267: public static class P
extends Context {
On 2015/11/26 09:54:48, magjed_webrtc wrote:
> What is this?

....

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/EglBase14.java (right):

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/EglBase14.java:77: super(true);
On 2015/11/26 09:54:48, magjed_webrtc wrote:
> true /* dummy */

Done.

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1461083002/diff/140001/talk/app/webrtc/java/and...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:233:
CameraEventsHandler eventsHandler, EglBase.Context sharedEglContext) {
On 2015/11/26 09:54:48, magjed_webrtc wrote:
> Will this change not break external apps? Maybe keep the old create() and just
> wrap the EGLContext and call this create() instead/

No one seems to use this except for our demo yet. If we want to keep the old we
also have to add a new create method.

[magjed_webrtc, 2015-11-26 11:28:20]

lgtm

[perkj_webrtc, 2015-11-30 15:04:23]

perkj@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[perkj_webrtc, 2015-11-30 15:04:24]

Alex, do you want to take a look and have an opinion.

[perkj_webrtc, 2015-12-02 09:03:49]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2015-12-02 09:03:50]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1461083002/#ps240001 (title:
"Changed VideoRendererGui to return an EglBase.Context.")

[commit-bot: I haz the power, 2015-12-02 09:04:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461083002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461083002/240001

[perkj_webrtc, 2015-12-02 09:04:17]

Description was changed from

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
==========

to

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
TBR=glaznew@webrtc.org
==========

[commit-bot: I haz the power, 2015-12-02 09:07:22]

Description was changed from

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
TBR=glaznew@webrtc.org
==========

to

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
TBR=glaznew@webrtc.org
==========

[commit-bot: I haz the power, 2015-12-02 09:07:23]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2015-12-02 09:07:24]

Description was changed from

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
TBR=glaznew@webrtc.org
==========

to

==========
This cl change so that we use EGL14 where it is supported and EGL10 otherwise.
The idea is to make this agnostic to an application and for WebRTC except in
EGLBase.

The reason we want to use EGL14 is to be able to use
EGLExt.eglPresentationTimeANDROID when writing textures to MediaEncoder.

BUG=webrtc:4993
TBR=glaznew@webrtc.org

Committed: https://crrev.com/40455d6f37fda78ea069a51d95f28994bd736864
Cr-Commit-Position: refs/heads/master@{#10864}
==========

[commit-bot: I haz the power, 2015-12-02 09:07:25]

Patchset 13 (id:??) landed as
https://crrev.com/40455d6f37fda78ea069a51d95f28994bd736864
Cr-Commit-Position: refs/heads/master@{#10864}