Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1461053002: Cleaned up deprecated elapsed_time methods and changed rotation to be webrtc::VideoRotation (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Chrome has now been updated. CapturedFrame Removed deprecated elapsed_time. Changed rotation to be webrtc::VideoRotation. WebRTCVideoFrame Removed deprecated InitToBlack Removed deprecated constructors. Committed: https://crrev.com/7755e2064b5b8add2ff0c9d0b5d3fb34ee1726d1 Cr-Commit-Position: refs/heads/master@{#10718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -47 lines) Patch
M talk/app/webrtc/androidvideocapturer.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M talk/media/base/videocapturer.h View 2 chunks +1 line, -9 lines 0 comments Download
M talk/media/base/videocapturer.cc View 2 chunks +1 line, -6 lines 0 comments Download
M talk/media/base/videoframefactory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvideoframe.h View 2 chunks +0 lines, -9 lines 0 comments Download
M talk/media/webrtc/webrtcvideoframe.cc View 2 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
perkj_webrtc
Please?
5 years, 1 month ago (2015-11-19 13:57:12 UTC) #3
magjed_webrtc
lgtm
5 years, 1 month ago (2015-11-19 14:49:46 UTC) #4
guoweis_webrtc
On 2015/11/19 14:49:46, magjed_webrtc wrote: > lgtm lgtm
5 years, 1 month ago (2015-11-19 15:17:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461053002/1
5 years, 1 month ago (2015-11-19 20:00:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 20:02:25 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7755e2064b5b8add2ff0c9d0b5d3fb34ee1726d1 Cr-Commit-Position: refs/heads/master@{#10718}
5 years, 1 month ago (2015-11-19 20:02:44 UTC) #9
tfarina
5 years, 1 month ago (2015-11-20 18:09:02 UTC) #11
Message was sent while issue was closed.
lgtm!

I started doing it today, but when I rebased my patch I noticed it was already
done. Thanks!

Powered by Google App Engine
This is Rietveld 408576698