Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Unified Diff: talk/app/webrtc/java/jni/native_handle_impl.h

Issue 1460703002: Implement AndroidTextureBuffer::NativeToI420. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Get a shared ref to the java SurfaceTectureHelper. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/java/jni/native_handle_impl.h
diff --git a/talk/app/webrtc/java/jni/native_handle_impl.h b/talk/app/webrtc/java/jni/native_handle_impl.h
index 911a3c4fb690b81c1f395501c4f74824a695ed09..e8407abe2bb93061d80b1d32569201fe25a64595 100644
--- a/talk/app/webrtc/java/jni/native_handle_impl.h
+++ b/talk/app/webrtc/java/jni/native_handle_impl.h
@@ -39,9 +39,13 @@ namespace webrtc_jni {
struct NativeHandleImpl {
NativeHandleImpl(JNIEnv* jni,
jint j_oes_texture_id,
- jfloatArray j_transform_matrix);
+ jfloatArray j_transform_matrix,
+ jobject helper);
const int oes_texture_id;
+ // Raw object pointer, relying on AndroidVideoCapturerJni to keep a
magjed_webrtc 2015/12/03 12:33:58 Can't you place the |surface_texture_helper| in An
nisse-webrtc 2015/12/03 13:35:21 I can. And then the GetSurfaceHelper method is no
+ // global reference.
+ jobject surface_texture_helper;
float sampling_matrix[16];
};

Powered by Google App Engine
This is Rietveld 408576698