Implement AndroidTextureBuffer::NativeToI420.

talk/app/webrtc/java/android/org/webrtc/EglBase.java

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 69 matching lines @@
     EGL10.EGL_NONE
   };
   public static final int[] CONFIG_PIXEL_BUFFER = {
     EGL10.EGL_RED_SIZE, 8,
     EGL10.EGL_GREEN_SIZE, 8,
     EGL10.EGL_BLUE_SIZE, 8,
     EGL10.EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
     EGL10.EGL_SURFACE_TYPE, EGL10.EGL_PBUFFER_BIT,
     EGL10.EGL_NONE
   };
+  public static final int[] CONFIG_PIXEL_RGBA_BUFFER = {
+    EGL10.EGL_RED_SIZE, 8,
+    EGL10.EGL_GREEN_SIZE, 8,
+    EGL10.EGL_BLUE_SIZE, 8,
+    EGL10.EGL_ALPHA_SIZE, 8,
+    EGL10.EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
+    EGL10.EGL_SURFACE_TYPE, EGL10.EGL_PBUFFER_BIT,
+    EGL10.EGL_NONE
+  };
   public static final int[] CONFIG_RECORDABLE = {
     EGL10.EGL_RED_SIZE, 8,
     EGL10.EGL_GREEN_SIZE, 8,
     EGL10.EGL_BLUE_SIZE, 8,
     EGL10.EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
     EGL_RECORDABLE_ANDROID, 1,
     EGL10.EGL_NONE
   };
 
   // Create a new context with the specified config attributes, sharing data with sharedContext.
@@ skipping 140 matching lines @@
     if (eglSurface != EGL10.EGL_NO_SURFACE) {
       throw new RuntimeException("Already has an EGLSurface");
     }
     int[] surfaceAttribs = {EGL10.EGL_WIDTH, width, EGL10.EGL_HEIGHT, height, EGL10.EGL_NONE};
     eglSurface = egl.eglCreatePbufferSurface(eglDisplay, eglConfig, surfaceAttribs);
     if (eglSurface == EGL10.EGL_NO_SURFACE) {
       throw new RuntimeException("Failed to create pixel buffer surface");
     }
   }
 
+  // Ensure we have a pixel buffer surface of the right size.
+  public void withPbufferSurface(int width, int height) {

[perkj_webrtc, 2015/12/10 10:15:53]

I would prefer if put this this helper method where you use it. If you add
something here you must also do the same in EglBase14 and it seems unnecessary.

If this is a helper where you use it I would call it createSurfaceOfSize or
something similar.

[nisse-webrtc, 2015/12/10 12:14:56]

I'll delete this method and inline the logic where it is used. It's only one
place (used to be two, with textureToRGBA).

+    if (hasSurface()) {
+      if (surfaceWidth() == width &&
+          surfaceHeight() == height)
+        // We already have a surface, and of the right size.
+        return;
+
+      releaseSurface();
+    }
+    createPbufferSurface(width, height);
+  }
+
   public Context getEglBaseContext() {
     return new Context(eglContext);
   }
 
   public boolean hasSurface() {
     return eglSurface != EGL10.EGL_NO_SURFACE;
   }
 
   public int surfaceWidth() {
     final int widthArray[] = new int[1];
@@ skipping 89 matching lines @@
     EGLContext rootContext =
         sharedContext == null ? EGL10.EGL_NO_CONTEXT : sharedContext.eglContext;
     EGLContext eglContext =
         egl.eglCreateContext(eglDisplay, eglConfig, rootContext, contextAttributes);
     if (eglContext == EGL10.EGL_NO_CONTEXT) {
       throw new RuntimeException("Failed to create EGL context");
     }
     return eglContext;
   }
 }