Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1460483005: Removed dummy "mediastreamsignaling.h" (Closed)

Created:
5 years, 1 month ago by perkj_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed dummy "mediastreamsignaling.h" Committed: https://crrev.com/726b1f7a1467a33b1c3feedff84fca953f7f9c1d Cr-Commit-Position: refs/heads/master@{#10717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -205 lines) Patch
D talk/app/webrtc/mediastreamsignaling.h View 1 chunk +0 lines, -28 lines 0 comments Download
D talk/app/webrtc/mediastreamsignaling.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M talk/app/webrtc/statscollector.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D talk/app/webrtc/test/fakemediastreamsignaling.h View 1 chunk +0 lines, -140 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M talk/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
Can you please review and check the CQ if you think it is good? I ...
5 years, 1 month ago (2015-11-19 13:14:01 UTC) #2
Taylor Brandstetter
On 2015/11/19 13:14:01, perkj1 wrote: > Can you please review and check the CQ if ...
5 years, 1 month ago (2015-11-19 19:21:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460483005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460483005/1
5 years, 1 month ago (2015-11-19 19:59:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 20:01:07 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 20:01:15 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/726b1f7a1467a33b1c3feedff84fca953f7f9c1d
Cr-Commit-Position: refs/heads/master@{#10717}

Powered by Google App Engine
This is Rietveld 408576698