Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1459873002: Android: Make classes non-final (Closed)

Created:
5 years, 1 month ago by magjed_webrtc
Modified:
5 years, 1 month ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Make classes non-final The classes are not mockable if they are final. R=phoglund@webrtc.org Committed: https://crrev.com/ef453238aaf9d4b5c7ded9519c571e56205b0978 Cr-Commit-Position: refs/heads/master@{#10714}

Patch Set 1 #

Patch Set 2 : Make SurfaceTextureHelper non-final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/EglBase.java View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/java/android/org/webrtc/SurfaceTextureHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
magjed_webrtc
phoglund - Please take a look.
5 years, 1 month ago (2015-11-19 13:17:34 UTC) #3
phoglund
Do this for SurfaceTextureHelper as well; I found that was marked final too by git ...
5 years, 1 month ago (2015-11-19 13:52:44 UTC) #4
phoglund
lgtm
5 years, 1 month ago (2015-11-19 14:51:40 UTC) #6
magjed_webrtc
I made SurfaceTextureHelper non-final as well. Please take another look.
5 years, 1 month ago (2015-11-19 14:51:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459873002/20001
5 years, 1 month ago (2015-11-19 14:52:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-19 16:51:22 UTC) #11
magjed_webrtc
Committed patchset #2 (id:20001) manually as ef453238aaf9d4b5c7ded9519c571e56205b0978 (presubmit successful).
5 years, 1 month ago (2015-11-19 16:54:21 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:54:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef453238aaf9d4b5c7ded9519c571e56205b0978
Cr-Commit-Position: refs/heads/master@{#10714}

Powered by Google App Engine
This is Rietveld 408576698