Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1459193002: Extract the parameters for the encoder stack from the CodecManager (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Extract the parameters for the encoder stack from the CodecManager BUG=webrtc:5028 Committed: https://crrev.com/1379f1f1e69632485d07ac7a3a575ea231e62522 Cr-Commit-Position: refs/heads/master@{#10750}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -136 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_manager.h View 2 chunks +3 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 12 chunks +40 lines, -76 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.h View 1 chunk +19 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.cc View 2 chunks +33 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec_unittest.cc View 4 chunks +12 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
5 years, 1 month ago (2015-11-23 10:33:38 UTC) #5
hlundin-webrtc
lgtm
5 years, 1 month ago (2015-11-23 12:21:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459193002/40001
5 years, 1 month ago (2015-11-23 12:25:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-11-23 12:30:56 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 12:31:00 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1379f1f1e69632485d07ac7a3a575ea231e62522
Cr-Commit-Position: refs/heads/master@{#10750}

Powered by Google App Engine
This is Rietveld 408576698