Re-enable mistakenly disabled PEM tests. Misc cleanup and alignment fixes.

Re-enable mistakenly disabled PEM tests. Misc cleanup and alignment fixes.

BUG=

Committed: https://crrev.com/7593aad1634c2ab88351a56eca108cb6af9a274e
Cr-Commit-Position: refs/heads/master@{#10719}

[torbjorng (webrtc), 2015-11-19 14:49:07]

Description was changed from

==========
Re-enable mistakenly disable PEM tests. Misc cleanup and alignment fixes.

BUG=
==========

to

==========
Re-enable mistakenly disable PEM tests. Misc cleanup and alignment fixes.

BUG=
==========

[torbjorng (webrtc), 2015-11-19 14:49:08]

torbjorng@webrtc.org changed reviewers:
+ tommi@webrtc.org

[torbjorng (webrtc), 2015-11-19 14:49:30]

Please take a look, tommi.

[torbjorng (webrtc), 2015-11-19 14:50:29]

Description was changed from

==========
Re-enable mistakenly disable PEM tests. Misc cleanup and alignment fixes.

BUG=
==========

to

==========
Re-enable mistakenly disabled PEM tests. Misc cleanup and alignment fixes.

BUG=
==========

[tommi, 2015-11-19 15:02:29]

lgtm % nits

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
File webrtc/base/sslstreamadapter_unittest.cc (right):

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
webrtc/base/sslstreamadapter_unittest.cc:690: unsigned int randstate = sent_;
int rand_state
(same type as sent_)

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
webrtc/base/sslstreamadapter_unittest.cc:693: randstate = (randstate * 251 +
19937) >> 7;
can you add some explanation for these constants?

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
webrtc/base/sslstreamadapter_unittest.cc:740: unsigned int randstate =
packet_num;
rand_state

[torbjorng (webrtc), 2015-11-19 15:20:02]

Thanks.

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
File webrtc/base/sslstreamadapter_unittest.cc (right):

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
webrtc/base/sslstreamadapter_unittest.cc:690: unsigned int randstate = sent_;
On 2015/11/19 15:02:29, tommi (webrtc) wrote:
> int rand_state
> (same type as sent_)

Fixing name.

I made this 'unsigned' as it relies on well-defined overflow semantics.

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
webrtc/base/sslstreamadapter_unittest.cc:693: randstate = (randstate * 251 +
19937) >> 7;
On 2015/11/19 15:02:29, tommi (webrtc) wrote:
> can you add some explanation for these constants?

Not really. :-)  It's a simple LC generator without any claim of great
properties except that it won't have a short cycle.  It's an improvement over
the unaligned write+read and repeated sequence number pattern.

https://codereview.webrtc.org/1459153002/diff/1/webrtc/base/sslstreamadapter_...
webrtc/base/sslstreamadapter_unittest.cc:740: unsigned int randstate =
packet_num;
On 2015/11/19 15:02:29, tommi (webrtc) wrote:
> rand_state

Done.

[torbjorng (webrtc), 2015-11-19 15:21:24]

The CQ bit was checked by torbjorng@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 15:21:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459153002/20001

[commit-bot: I haz the power, 2015-11-19 17:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 17:21:41]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[torbjorng (webrtc), 2015-11-19 17:48:22]

The CQ bit was checked by torbjorng@webrtc.org

[torbjorng (webrtc), 2015-11-19 17:48:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1459153002/#ps20001 (title:
"Address tommi's comments.")

[commit-bot: I haz the power, 2015-11-19 17:48:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459153002/20001

[commit-bot: I haz the power, 2015-11-19 20:20:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 20:20:59]

Patchset 2 (id:??) landed as
https://crrev.com/7593aad1634c2ab88351a56eca108cb6af9a274e
Cr-Commit-Position: refs/heads/master@{#10719}