Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1459083007: Open backdoor in VoiceEngineImpl to get at the actual voe::Channel objects from an ID. (Closed)

Created:
5 years, 1 month ago by the sun
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, minyue-webrtc, kwiberg-webrtc, Stefan
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Open backdoor in VoiceEngineImpl to get at the actual voe::Channel objects from an ID. This will allow Audio[Send|Receive]Stream to bypass the VoE interfaces in many cases and talk directly to the channel. BUG=webrtc:4690 Committed: https://crrev.com/13725089ef91f932b37b2447c3f05d9cd9f89984 Cr-Commit-Position: refs/heads/master@{#10788}

Patch Set 1 #

Patch Set 2 : Introduce ChannelProxy to avoid mocking all of voe::Channel #

Patch Set 3 : add the new files #

Patch Set 4 : Add default mock behavior to simplify test setup #

Patch Set 5 : small fixes #

Patch Set 6 : rebase #

Total comments: 16

Patch Set 7 : fix win64 gn build error #

Patch Set 8 : comments #

Total comments: 2

Patch Set 9 : presubmit complaints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -78 lines) Patch
M webrtc/audio/audio_receive_stream.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -6 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 2 3 4 5 6 7 6 chunks +13 lines, -3 lines 0 comments Download
M webrtc/audio/audio_send_stream.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 2 3 4 5 6 7 3 chunks +12 lines, -11 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 2 3 4 5 6 7 4 chunks +12 lines, -6 lines 0 comments Download
A + webrtc/test/mock_voe_channel_proxy.h View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -14 lines 0 comments Download
M webrtc/test/mock_voice_engine.h View 1 2 3 4 5 6 7 2 chunks +15 lines, -0 lines 0 comments Download
M webrtc/test/webrtc_test_common.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/voice_engine/channel_proxy.h View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
A webrtc/voice_engine/channel_proxy.cc View 1 2 3 4 5 6 7 1 chunk +44 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.h View 1 2 3 4 5 6 1 chunk +42 lines, -22 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 1 2 3 4 5 6 3 chunks +19 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 1 2 3 4 5 6 7 3 chunks +8 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.cc View 1 2 3 4 5 6 7 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
the sun
5 years ago (2015-11-24 09:49:21 UTC) #3
the sun
On 2015/11/24 09:49:21, the sun wrote: Added pbos@ for webrtc/test
5 years ago (2015-11-24 16:13:52 UTC) #6
pbos-webrtc
rs-lgtm for webrtc/test
5 years ago (2015-11-24 16:28:48 UTC) #7
kwiberg-webrtc
https://codereview.webrtc.org/1459083007/diff/100001/webrtc/audio/audio_receive_stream_unittest.cc File webrtc/audio/audio_receive_stream_unittest.cc (right): https://codereview.webrtc.org/1459083007/diff/100001/webrtc/audio/audio_receive_stream_unittest.cc#newcode68 webrtc/audio/audio_receive_stream_unittest.cc:68: .WillOnce(Invoke(this, &ConfigHelper::CreateChannelProxy)); Can you do this with a lambda ...
5 years ago (2015-11-25 10:44:59 UTC) #8
the sun
https://codereview.webrtc.org/1459083007/diff/100001/webrtc/audio/audio_receive_stream_unittest.cc File webrtc/audio/audio_receive_stream_unittest.cc (right): https://codereview.webrtc.org/1459083007/diff/100001/webrtc/audio/audio_receive_stream_unittest.cc#newcode68 webrtc/audio/audio_receive_stream_unittest.cc:68: .WillOnce(Invoke(this, &ConfigHelper::CreateChannelProxy)); On 2015/11/25 10:44:58, kwiberg-webrtc wrote: > Can ...
5 years ago (2015-11-25 12:28:02 UTC) #9
kwiberg-webrtc
lgtm https://codereview.webrtc.org/1459083007/diff/140001/webrtc/voice_engine/voe_base_impl.h File webrtc/voice_engine/voe_base_impl.h (right): https://codereview.webrtc.org/1459083007/diff/140001/webrtc/voice_engine/voe_base_impl.h#newcode66 webrtc/voice_engine/voe_base_impl.h:66: uint32_t& newMicLevel) override; Making arguments const like this ...
5 years ago (2015-11-25 12:56:57 UTC) #10
the sun
https://codereview.webrtc.org/1459083007/diff/140001/webrtc/voice_engine/voe_base_impl.h File webrtc/voice_engine/voe_base_impl.h (right): https://codereview.webrtc.org/1459083007/diff/140001/webrtc/voice_engine/voe_base_impl.h#newcode66 webrtc/voice_engine/voe_base_impl.h:66: uint32_t& newMicLevel) override; On 2015/11/25 12:56:57, kwiberg-webrtc wrote: > ...
5 years ago (2015-11-25 13:06:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459083007/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459083007/140001
5 years ago (2015-11-25 13:07:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1970)
5 years ago (2015-11-25 13:09:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459083007/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459083007/160001
5 years ago (2015-11-25 13:23:29 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-11-25 15:23:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459083007/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459083007/160001
5 years ago (2015-11-25 15:36:54 UTC) #23
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years ago (2015-11-25 16:16:56 UTC) #24
commit-bot: I haz the power
5 years ago (2015-11-25 16:17:05 UTC) #25
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/13725089ef91f932b37b2447c3f05d9cd9f89984
Cr-Commit-Position: refs/heads/master@{#10788}

Powered by Google App Engine
This is Rietveld 408576698