Issue 1458853002: Remove spammy logging of RTCP delivery failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1458853002: Remove spammy logging of RTCP delivery failures. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc

Modified:
5 years, 1 month ago

Reviewers:
henrika_webrtc

CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Remove spammy logging of RTCP delivery failures. Since BundleFilter doesn't filter RTCP anymore we can have incoming RTCPs for audio delivered to video, that delivery will fail when there are no video receivers causing the log to be spammed. BUG=webrtc:5223 R=henrika@webrtc.org Committed: https://crrev.com/2aff615bd7c7c24a6e7a35163112f169ff4f9246 Cr-Commit-Position: refs/heads/master@{#10687}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	talk/media/webrtc/webrtcvideoengine2.cc	View		1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pbos-webrtc

Committed patchset #1 (id:1) manually as 2aff615bd7c7c24a6e7a35163112f169ff4f9246 (presubmit successful).

5 years, 1 month ago (2015-11-18 12:47:31 UTC) #3

commit-bot: I haz the power

5 years, 1 month ago (2015-11-18 12:47:35 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2aff615bd7c7c24a6e7a35163112f169ff4f9246
Cr-Commit-Position: refs/heads/master@{#10687}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages