Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1458763002: So long and thanks for all the code reviews! (Closed)

Created:
5 years, 1 month ago by Andrew MacDonald
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

So long and thanks for all the code reviews! - Remove myself from OWNERS. - Add myself to AUTHORS (I signed a CLA). - Add minyue to audio_conference_mixer which would otherwise be empty. - Add missing comma in WATCHLISTS. Committed: https://crrev.com/f70568c04b6e5ce77f7dff5fe4c990fbcc5d0bc8 Cr-Commit-Position: refs/heads/master@{#10686}

Patch Set 1 #

Patch Set 2 : Add myself to AUTHORS. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M WATCHLISTS View 1 chunk +1 line, -1 line 1 comment Download
M tools/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Andrew MacDonald
5 years, 1 month ago (2015-11-18 02:08:52 UTC) #3
aluebs-webrtc
Thank you, Andrew! :) It is an honor to have coded by your side. Hope ...
5 years, 1 month ago (2015-11-18 02:41:19 UTC) #5
Andrew MacDonald
On 2015/11/18 02:41:19, aluebs-webrtc wrote: > Thank you, Andrew! :) > It is an honor ...
5 years, 1 month ago (2015-11-18 03:59:17 UTC) #7
kwiberg-webrtc
On 2015/11/18 03:59:17, Andrew MacDonald wrote: > On 2015/11/18 02:41:19, aluebs-webrtc wrote: > > Thank ...
5 years, 1 month ago (2015-11-18 07:22:44 UTC) #8
tommi
lgtm *sniff* Best of luck with everything :-) https://codereview.webrtc.org/1458763002/diff/20001/WATCHLISTS File WATCHLISTS (right): https://codereview.webrtc.org/1458763002/diff/20001/WATCHLISTS#newcode102 WATCHLISTS:102: 'peah@webrtc.org', ...
5 years, 1 month ago (2015-11-18 07:44:41 UTC) #9
minyue-webrtc
On 2015/11/18 07:44:41, tommi (webrtc) wrote: > lgtm *sniff* > Best of luck with everything ...
5 years, 1 month ago (2015-11-18 09:15:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458763002/20001
5 years, 1 month ago (2015-11-18 10:15:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 11:07:44 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 11:08:00 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f70568c04b6e5ce77f7dff5fe4c990fbcc5d0bc8
Cr-Commit-Position: refs/heads/master@{#10686}

Powered by Google App Engine
This is Rietveld 408576698