Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458023002: Reland Convert internal representation of Srtp cryptos from string to int (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years, 1 month ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Convert internal representation of Srtp cryptos from string to int TBR=pthatcher@webrtc.org BUG=webrtc:5043 Committed: https://crrev.com/521ed7bf022c4e30574d7970c2be5be46567f4cd Cr-Commit-Position: refs/heads/master@{#10703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -349 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 9 chunks +21 lines, -21 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 3 chunks +20 lines, -23 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M talk/media/base/cryptoparams.h View 1 chunk +4 lines, -2 lines 0 comments Download
M talk/session/media/channel.h View 5 chunks +6 lines, -7 lines 0 comments Download
M talk/session/media/channel.cc View 7 chunks +26 lines, -35 lines 0 comments Download
M talk/session/media/mediasession.h View 1 chunk +13 lines, -4 lines 0 comments Download
M talk/session/media/mediasession.cc View 5 chunks +46 lines, -15 lines 0 comments Download
M talk/session/media/srtpfilter.h View 3 chunks +7 lines, -7 lines 0 comments Download
M talk/session/media/srtpfilter.cc View 6 chunks +16 lines, -17 lines 0 comments Download
M talk/session/media/srtpfilter_unittest.cc View 10 chunks +46 lines, -56 lines 0 comments Download
M webrtc/base/opensslstreamadapter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 8 chunks +21 lines, -27 lines 0 comments Download
M webrtc/base/sslstreamadapter.h View 5 chunks +15 lines, -8 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 4 chunks +18 lines, -10 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 3 chunks +44 lines, -47 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 4 chunks +12 lines, -13 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 chunk +8 lines, -5 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
guoweis_webrtc
Committed patchset #1 (id:1) manually as 521ed7bf022c4e30574d7970c2be5be46567f4cd (presubmit successful).
5 years, 1 month ago (2015-11-19 03:42:04 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 03:42:06 UTC) #3
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/521ed7bf022c4e30574d7970c2be5be46567f4cd
Cr-Commit-Position: refs/heads/master@{#10703}

Powered by Google App Engine
This is Rietveld 408576698