Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1458013004: Make it extra safe when deleting a turn entry. (Closed)

Created:
5 years, 1 month ago by honghaiz3
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make it extra safe when deleting a turn entry. Check if it is in the list of turn entries before attempting to delete it. BUG= Committed: https://crrev.com/c3e0fe7c21a6c6c367ce38b54634dc38f6222693 Cr-Commit-Position: refs/heads/master@{#10877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/p2p/base/turnport.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
honghaiz3
5 years, 1 month ago (2015-11-21 00:18:13 UTC) #2
pthatcher1
lgtm
5 years ago (2015-12-02 22:38:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458013004/1
5 years ago (2015-12-02 23:46:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 00:43:29 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 00:43:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3e0fe7c21a6c6c367ce38b54634dc38f6222693
Cr-Commit-Position: refs/heads/master@{#10877}

Powered by Google App Engine
This is Rietveld 408576698