Remove SetVideoLogging/SetAudioLogging from ChannelManager and down the stack.

talk/media/webrtc/webrtcvoiceengine.h

Index: talk/media/webrtc/webrtcvoiceengine.h
diff --git a/talk/media/webrtc/webrtcvoiceengine.h b/talk/media/webrtc/webrtcvoiceengine.h
index 2f74dabd0f486fbaa165faec8e93ada088334094..33104539846ab09c3cb445f8bdedc968497e7e75 100644
--- a/talk/media/webrtc/webrtcvoiceengine.h
+++ b/talk/media/webrtc/webrtcvoiceengine.h
@@ -86,8 +86,6 @@ class WebRtcVoiceEngine final : public webrtc::TraceCallback  {
 
   const std::vector<RtpHeaderExtension>& rtp_header_extensions() const;
 
-  void SetLogging(int min_sev, const char* filter);
-
   // For tracking WebRtc channels. Needed because we have to pause them
   // all when switching devices.
   // May only be called by WebRtcVoiceMediaChannel.
@@ -122,8 +120,8 @@ class WebRtcVoiceEngine final : public webrtc::TraceCallback  {
   void ConstructCodecs();
   bool GetVoeCodec(int index, webrtc::CodecInst* codec);
   bool InitInternal();
-  void SetTraceFilter(int filter);
-  void SetTraceOptions(const std::string& options);
+  void SetTraceFilter(int filter);                    // !!!!!!!!!! Remove?
+  void SetTraceOptions(const std::string& options);   // !!!!!!!!!! Remove?

[pthatcher1, 2015/11/18 19:26:26]

If these only have an effect when SetLogging is called and SetLogging is going
away, then yes, they should go away.

[the sun, 2015/11/19 15:55:12]

Done.

   // Every option that is "set" will be applied. Every option not "set" will be
   // ignored. This allows us to selectively turn on and off different options
   // easily at any time.
@@ -152,7 +150,7 @@ class WebRtcVoiceEngine final : public webrtc::TraceCallback  {
   // The external audio device manager
   webrtc::AudioDeviceModule* adm_ = nullptr;
   int log_filter_;
-  std::string log_options_;
+  std::string log_options_;           // !!!!!!!!!!! Remove?

[pthatcher1, 2015/11/18 19:26:26]

If SetLogging is the only thing that sets it, and SetLogging is going away, then
yes, it should go away as well.

[the sun, 2015/11/19 15:55:12]

Yes, as well as some other stuff.

   bool is_dumping_aec_ = false;
   std::vector<AudioCodec> codecs_;
   std::vector<RtpHeaderExtension> rtp_header_extensions_;