Remove SetVideoLogging/SetAudioLogging from ChannelManager and down the stack.

talk/media/webrtc/webrtcvoiceengine_unittest.cc

 /*
  * libjingle
  * Copyright 2008 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 2299 matching lines @@
   options.playout_sample_rate = rtc::Optional<uint32_t>(44100);
   EXPECT_TRUE(engine_.SetOptions(options));
 
   unsigned int recording_sample_rate, playout_sample_rate;
   EXPECT_EQ(0, voe_.RecordingSampleRate(&recording_sample_rate));
   EXPECT_EQ(0, voe_.PlayoutSampleRate(&playout_sample_rate));
   EXPECT_EQ(48000u, recording_sample_rate);
   EXPECT_EQ(44100u, playout_sample_rate);
 }
 
+/*  !!!!!!!!!!!!!!!! Fix!
+
 TEST_F(WebRtcVoiceEngineTestFake, TraceFilterViaTraceOptions) {
   EXPECT_TRUE(SetupEngineWithSendStream());
   engine_.SetLogging(rtc::LS_INFO, "");
   EXPECT_EQ(
       // Info:
       webrtc::kTraceStateInfo | webrtc::kTraceInfo |
       // Warning:
       webrtc::kTraceTerseInfo | webrtc::kTraceWarning |
       // Error:
       webrtc::kTraceError | webrtc::kTraceCritical,
       static_cast<int>(trace_wrapper_->filter_));
   // Now set it explicitly
   std::string filter =
       "tracefilter " + rtc::ToString(webrtc::kTraceDefault);
   engine_.SetLogging(rtc::LS_VERBOSE, filter.c_str());
   EXPECT_EQ(static_cast<unsigned int>(webrtc::kTraceDefault),
             trace_wrapper_->filter_);
 }
+*/

[pthatcher1, 2015/11/18 19:26:26]

Wouldn't this test just go away?

[the sun, 2015/11/19 15:55:12]

Done.

 
 // Test that we can set the outgoing SSRC properly.
 // SSRC is set in SetupEngine by calling AddSendStream.
 TEST_F(WebRtcVoiceEngineTestFake, SetSendSsrc) {
   EXPECT_TRUE(SetupEngineWithSendStream());
   EXPECT_TRUE(call_.GetAudioSendStream(kSsrc1));
 }
 
 TEST_F(WebRtcVoiceEngineTestFake, GetStats) {
   // Setup. We need send codec to be set to get all stats.
@@ skipping 972 matching lines @@
   cricket::WebRtcVoiceEngine engine;
   EXPECT_TRUE(engine.Init(rtc::Thread::Current()));
   rtc::scoped_ptr<webrtc::Call> call(
       webrtc::Call::Create(webrtc::Call::Config()));
   cricket::WebRtcVoiceMediaChannel channel(&engine, cricket::AudioOptions(),
                                            call.get());
   cricket::AudioRecvParameters parameters;
   parameters.codecs = engine.codecs();
   EXPECT_TRUE(channel.SetRecvParameters(parameters));
 }