Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457283002: Re-enable RestartingSendStreamPreservesRtpState. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable RestartingSendStreamPreservesRtpState. BUG=webrtc:3552 R=kjellander@webrtc.org

Patch Set 1 #

Patch Set 2 : stricter check #

Patch Set 3 : lol fix bogus patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-memcheck.txt View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457283002/1
5 years, 1 month ago (2015-11-19 11:59:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/8099)
5 years, 1 month ago (2015-11-19 12:39:23 UTC) #4
pbos-webrtc
stricter check
5 years, 1 month ago (2015-11-19 16:30:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457283002/20001
5 years, 1 month ago (2015-11-19 16:30:50 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/10724) mac_compile_dbg on ...
5 years, 1 month ago (2015-11-19 16:32:05 UTC) #9
pbos-webrtc
lol fix bogus patch
5 years, 1 month ago (2015-11-19 16:32:45 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457283002/40001
5 years, 1 month ago (2015-11-19 16:35:48 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/8114)
5 years, 1 month ago (2015-11-19 16:54:25 UTC) #14
kjellander_webrtc
will you try to land this?
5 years ago (2015-11-24 21:09:40 UTC) #15
pbos-webrtc
On 2015/11/24 21:09:40, kjellander (webrtc) wrote: > will you try to land this? Yeah it's ...
5 years ago (2015-11-26 14:16:59 UTC) #16
kjellander_webrtc
On 2015/11/26 14:16:59, pbos-webrtc wrote: > On 2015/11/24 21:09:40, kjellander (webrtc) wrote: > > will ...
4 years, 10 months ago (2016-02-01 05:24:19 UTC) #17
pbos-webrtc
4 years, 10 months ago (2016-02-02 16:18:43 UTC) #18 
Asked Danil to take a look.

Powered by Google App Engine
This is Rietveld 408576698