Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using (https://codereview.chromium.org/1450313002/).
It will also pave the road for enabling more WebRTC native tests on iOS.

BUG=webrtc:4755, webrtc:3185, webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm chromium_ios_signing=0' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm64' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=ia32' webrtc/build/gyp_webrtc
ninja -C out/Release-iphonesimulator
GYP_DEFINES='OS=ios target_arch=x64' webrtc/build/gyp_webrtc
ninja -C out/Release-iphonesimulator

R=henrika@webrtc.org

Committed: https://crrev.com/f22695c3d80b7b28fa3d7cb65cfda1af3d3eab16
Cr-Commit-Position: refs/heads/master@{#10711}

[kjellander_webrtc, 2015-11-19 12:41:37]

Description was changed from

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
==========

to

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

[kjellander_webrtc, 2015-11-19 12:41:38]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[kjellander_webrtc, 2015-11-19 12:43:44]

Description was changed from

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
==========

to

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

[kjellander_webrtc, 2015-11-19 12:44:54]

Description was changed from

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

to

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using. It will also pave the road for enabling
more WebRTC native tests on iOS.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

[kjellander_webrtc, 2015-11-19 12:45:43]

Description was changed from

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using. It will also pave the road for enabling
more WebRTC native tests on iOS.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

to

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using (https://codereview.chromium.org/1450313002/). 
It will also pave the road for enabling more WebRTC native tests on iOS.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

[kjellander_webrtc, 2015-11-19 12:53:57]

Description was changed from

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using (https://codereview.chromium.org/1450313002/). 
It will also pave the road for enabling more WebRTC native tests on iOS.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

to

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using (https://codereview.chromium.org/1450313002/). 
It will also pave the road for enabling more WebRTC native tests on iOS.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm chromium_ios_signing=0'
webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm64' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

[kjellander_webrtc, 2015-11-19 13:08:04]

I finally took some time to clean this up.
With this, 'all' builds for iOS with the default configuration, and we can say
goodbye to the confusing build_with_libjingle variable.

https://codereview.webrtc.org/1457053003/diff/1/webrtc/voice_engine/voice_eng...
File webrtc/voice_engine/voice_engine.gyp (right):

https://codereview.webrtc.org/1457053003/diff/1/webrtc/voice_engine/voice_eng...
webrtc/voice_engine/voice_engine.gyp:168: ['OS!="ios"', {
This is just moved, no changes.

[henrika_webrtc, 2015-11-19 13:10:32]

Amazing work. Thanks!

LGTM

[kjellander_webrtc, 2015-11-19 13:16:49]

On 2015/11/19 13:10:32, henrika_webrtc wrote:
> Amazing work. Thanks!
> 
> LGTM

Argh, I forgot about Intel. Will need more work. I'll see if I can get it fixed.

[kjellander_webrtc, 2015-11-19 14:37:58]

Description was changed from

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using (https://codereview.chromium.org/1450313002/). 
It will also pave the road for enabling more WebRTC native tests on iOS.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm chromium_ios_signing=0'
webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm64' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
==========

to

==========
Remove build_with_libjingle and exclude failing iOS tests from 'All' target.

This will make it possible to remove the build_with_libjingle=1 and key=''
GYP_DEFINES the bots are using (https://codereview.chromium.org/1450313002/). 
It will also pave the road for enabling more WebRTC native tests on iOS.

BUG=webrtc:4755,webrtc:3185,webrtc:5165
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel
--bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel
--bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m
tryserver.webrtc
Local compilation with:
GYP_DEFINES='OS=ios target_arch=arm' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm chromium_ios_signing=0'
webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=arm64' webrtc/build/gyp_webrtc
ninja -C out/Release-iphoneos
GYP_DEFINES='OS=ios target_arch=ia32' webrtc/build/gyp_webrtc
ninja -C out/Release-iphonesimulator
GYP_DEFINES='OS=ios target_arch=x64' webrtc/build/gyp_webrtc
ninja -C out/Release-iphonesimulator
==========

[kjellander_webrtc, 2015-11-19 14:38:33]

There we go. Properly tested on ia32 and x64. Only needed to exclude
modules_unittests as well (but kept it for ARM since it's working there).

https://codereview.webrtc.org/1457053003/diff/40001/webrtc/modules/modules.gyp
File webrtc/modules/modules.gyp (right):

https://codereview.webrtc.org/1457053003/diff/40001/webrtc/modules/modules.gy...
webrtc/modules/modules.gyp:108: 'targets': [
This is also just a pristine move of the target into the condition block.

[kjellander_webrtc, 2015-11-19 14:40:02]

Committed patchset #3 (id:40001) manually as
f22695c3d80b7b28fa3d7cb65cfda1af3d3eab16 (presubmit successful).

[commit-bot: I haz the power, 2015-11-19 14:40:02]

Patchset 3 (id:??) landed as
https://crrev.com/f22695c3d80b7b28fa3d7cb65cfda1af3d3eab16
Cr-Commit-Position: refs/heads/master@{#10711}