Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: webrtc/modules/audio_processing/aec/aec_core_internal.h

Issue 1456123003: Ducking fix #3: Removed the state as an input to the FilterAdaptation function (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@Aec_Code_Cleanup2_CL
Patch Set: Changes in response to reviewer comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/aec/aec_core_internal.h
diff --git a/webrtc/modules/audio_processing/aec/aec_core_internal.h b/webrtc/modules/audio_processing/aec/aec_core_internal.h
index 40a04c0a3f3cd714e731097e5549554ea37d0f3a..ae887f691e43c5cce6bd8e2790460f1c2a33b2b2 100644
--- a/webrtc/modules/audio_processing/aec/aec_core_internal.h
+++ b/webrtc/modules/audio_processing/aec/aec_core_internal.h
@@ -172,20 +172,23 @@ struct AecCore {
typedef void (*WebRtcAecFilterFar)(
int num_partitions,
- int xfBufBlockPos,
- float xfBuf[2][kExtendedNumPartitions * PART_LEN1],
- float wfBuf[2][kExtendedNumPartitions * PART_LEN1],
- float yf[2][PART_LEN1]);
+ int x_fft_buf_block_pos,
+ const float x_fft_buf[2][kExtendedNumPartitions * PART_LEN1],
+ const float h_fft_buf[2][kExtendedNumPartitions * PART_LEN1],
+ float y_fft[2][PART_LEN1]);
extern WebRtcAecFilterFar WebRtcAec_FilterFar;
typedef void (*WebRtcAecScaleErrorSignal)(int extended_filter_enabled,
float normal_mu,
float normal_error_threshold,
- float* xPow,
+ const float xPow[PART_LEN1],
hlundin-webrtc 2015/11/24 13:51:44 x_pow
peah-webrtc 2015/11/26 05:55:17 Done.
float ef[2][PART_LEN1]);
extern WebRtcAecScaleErrorSignal WebRtcAec_ScaleErrorSignal;
-typedef void (*WebRtcAecFilterAdaptation)(AecCore* aec,
- float* fft,
- float ef[2][PART_LEN1]);
+typedef void (*WebRtcAecFilterAdaptation)(
+ int num_partitions,
+ int x_fft_buf_block_pos,
+ const float x_fft_buf[2][kExtendedNumPartitions * PART_LEN1],
+ const float e_fft[2][PART_LEN1],
+ float h_fft_buf[2][kExtendedNumPartitions * PART_LEN1]);
extern WebRtcAecFilterAdaptation WebRtcAec_FilterAdaptation;
typedef void (*WebRtcAecOverdriveAndSuppress)(AecCore* aec,
float hNl[PART_LEN1],

Powered by Google App Engine
This is Rietveld 408576698