webrtc/modules/audio_processing/aec/aec_core_internal.h - Issue 1456123003: Ducking fix #3: Removed the state as an input to the FilterAdaptation function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec/aec_core_internal.h

Issue 1456123003: Ducking fix #3: Removed the state as an input to the FilterAdaptation function (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@Aec_Code_Cleanup2_CL

Patch Set: Various refactoring, among other things simplification of the EchoSubtraction function Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_processing/aec/aec_core.c ('K') | « webrtc/modules/audio_processing/aec/aec_core.c ('k') | webrtc/modules/audio_processing/aec/aec_core_mips.c » ('j') | webrtc/modules/audio_processing/aec/aec_core_mips.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/aec/aec_core_internal.h

diff --git a/webrtc/modules/audio_processing/aec/aec_core_internal.h b/webrtc/modules/audio_processing/aec/aec_core_internal.h

index 40a04c0a3f3cd714e731097e5549554ea37d0f3a..9dd457ef0c2d9c32a305564ff7fa0f0655aa6966 100644

--- a/webrtc/modules/audio_processing/aec/aec_core_internal.h

+++ b/webrtc/modules/audio_processing/aec/aec_core_internal.h

@@ -180,12 +180,15 @@ extern WebRtcAecFilterFar WebRtcAec_FilterFar;

typedef void (*WebRtcAecScaleErrorSignal)(int extended_filter_enabled,

float normal_mu,

float normal_error_threshold,

- float* xPow,

+ float xPow[PART_LEN1],

hlundin-webrtc 2015/11/20 11:55:20 Can x_pow be made const?

hlundin-webrtc 2015/11/20 11:55:20 x_pow

peah-webrtc 2015/11/24 13:03:01 Done.

float ef[2][PART_LEN1]);

extern WebRtcAecScaleErrorSignal WebRtcAec_ScaleErrorSignal;

-typedef void (*WebRtcAecFilterAdaptation)(AecCore* aec,

- float* fft,

- float ef[2][PART_LEN1]);

+typedef void (*WebRtcAecFilterAdaptation)(

+ int num_partitions,

+ int xfBufBlockPos,

+ float xfBuf[2][kExtendedNumPartitions * PART_LEN1],

+ float ef[2][PART_LEN1],

+ float wfBuf[2][kExtendedNumPartitions * PART_LEN1]);

extern WebRtcAecFilterAdaptation WebRtcAec_FilterAdaptation;

typedef void (*WebRtcAecOverdriveAndSuppress)(AecCore* aec,

float hNl[PART_LEN1],