Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1455233005: Revert of Convert internal representation of Srtp cryptos from string to int. (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Convert internal representation of Srtp cryptos from string to int. (patchset #10 id:180001 of https://codereview.webrtc.org/1416673006/ ) Reason for revert: Broke chromium fyi build. Original issue's description: > Convert internal representation of Srtp cryptos from string to int. > > Note that the coversion from int to string happens in 3 places > 1) SDP layer from int to external names. mediasession.cc GetSupportedSuiteNames. > 2) for SSL_CTX_set_tlsext_use_srtp(), converting from int to internal names. > 3) stats collection also needs external names. > > External names are like AES_CM_128_HMAC_SHA1_80, specified in sslstreamadapter.cc. > Internal names are like SRTP_AES128_CM_SHA1_80, specified in opensslstreamadapter.cc. > > The conversion from string to int happens in one place only, SDP layer, SrtpFilter::ApplyParams(). > > BUG=webrtc:5043 > > Committed: https://crrev.com/2764e1027a08a5543e04b854a27a520801faf6eb > Cr-Commit-Position: refs/heads/master@{#10701} TBR=juberti@webrtc.org,pthatcher@webrtc.org,juberti@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5043 Committed: https://crrev.com/318166bed75dcbc00a7b79f715f9953aff9ffbc7 Cr-Commit-Position: refs/heads/master@{#10702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -402 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 9 chunks +21 lines, -21 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 3 chunks +23 lines, -20 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M talk/media/base/cryptoparams.h View 1 chunk +2 lines, -4 lines 0 comments Download
M talk/session/media/channel.h View 5 chunks +7 lines, -6 lines 0 comments Download
M talk/session/media/channel.cc View 7 chunks +37 lines, -28 lines 0 comments Download
M talk/session/media/mediasession.h View 1 chunk +4 lines, -13 lines 0 comments Download
M talk/session/media/mediasession.cc View 5 chunks +19 lines, -50 lines 0 comments Download
M talk/session/media/srtpfilter.h View 3 chunks +7 lines, -7 lines 0 comments Download
M talk/session/media/srtpfilter.cc View 6 chunks +17 lines, -16 lines 0 comments Download
M talk/session/media/srtpfilter_unittest.cc View 10 chunks +56 lines, -46 lines 0 comments Download
M webrtc/base/opensslstreamadapter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 8 chunks +27 lines, -21 lines 0 comments Download
M webrtc/base/sslstreamadapter.h View 5 chunks +8 lines, -15 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 4 chunks +10 lines, -18 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 3 chunks +57 lines, -54 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 4 chunks +13 lines, -12 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
guoweis_webrtc
Created Revert of Convert internal representation of Srtp cryptos from string to int.
5 years, 1 month ago (2015-11-19 03:03:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455233005/1
5 years, 1 month ago (2015-11-19 03:03:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 03:03:42 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 03:03:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/318166bed75dcbc00a7b79f715f9953aff9ffbc7
Cr-Commit-Position: refs/heads/master@{#10702}

Powered by Google App Engine
This is Rietveld 408576698