webrtc/modules/audio_processing/aec/aec_core_internal.h - Issue 1454983006: Ducking fix #2: Removed the aec state as an input parameter to the FilterFar function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec/aec_core_internal.h

Issue 1454983006: Ducking fix #2: Removed the aec state as an input parameter to the FilterFar function. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@Aec_Code_Cleanup_CL

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/aec/aec_core.c ('k') | webrtc/modules/audio_processing/aec/aec_core_mips.c » ('j') | webrtc/modules/audio_processing/aec/aec_core_neon.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/aec/aec_core_internal.h

diff --git a/webrtc/modules/audio_processing/aec/aec_core_internal.h b/webrtc/modules/audio_processing/aec/aec_core_internal.h

index 2dd6f726607df9bda7e7404032fc79525e5398ae..40a04c0a3f3cd714e731097e5549554ea37d0f3a 100644

--- a/webrtc/modules/audio_processing/aec/aec_core_internal.h

+++ b/webrtc/modules/audio_processing/aec/aec_core_internal.h

@@ -170,7 +170,12 @@ struct AecCore {

#endif

};

-typedef void (*WebRtcAecFilterFar)(AecCore* aec, float yf[2][PART_LEN1]);

+typedef void (*WebRtcAecFilterFar)(

+ int num_partitions,

+ int xfBufBlockPos,

hlundin-webrtc 2015/11/20 10:59:40 Let the new parameters be named according to our s

peah-webrtc 2015/11/24 06:48:56 Nice! I did that, and also changed the function va

+ float xfBuf[2][kExtendedNumPartitions * PART_LEN1],

+ float wfBuf[2][kExtendedNumPartitions * PART_LEN1],

+ float yf[2][PART_LEN1]);

extern WebRtcAecFilterFar WebRtcAec_FilterFar;

typedef void (*WebRtcAecScaleErrorSignal)(int extended_filter_enabled,

float normal_mu,