Move some receive stream configuration into webrtc::AudioReceiveStream.

Move some receive stream configuration into webrtc::AudioReceiveStream.

Simplify creation of VoE channels and Call streams in WVoMC.

BUG=webrtc:4690
Committed: https://crrev.com/7add0584390dcfb236165a6472ede6c2a94eaeed
Cr-Commit-Position: refs/heads/master@{#10731}

[the sun, 2015-11-18 13:51:40]

Description was changed from

==========
Move some send stream configuration into webrtc::AudioReceiveStream.

BUG=webrtc:4690
==========

to

==========
Move some send stream configuration into webrtc::AudioReceiveStream.

Simplify creation of VoE channels and Call streams in WVoMC.

BUG=webrtc:4690
==========

[the sun, 2015-11-18 13:52:09]

solenberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[the sun, 2015-11-18 14:01:00]

Description was changed from

==========
Move some send stream configuration into webrtc::AudioReceiveStream.

Simplify creation of VoE channels and Call streams in WVoMC.

BUG=webrtc:4690
==========

to

==========
Move some receive stream configuration into webrtc::AudioReceiveStream.

Simplify creation of VoE channels and Call streams in WVoMC.

BUG=webrtc:4690
==========

[the sun, 2015-11-19 16:04:23]

On 2015/11/18 13:52:10, the sun wrote:

tommi, if you're short on cycles, please reassign. :)

[tommi, 2015-11-19 16:06:05]

tommi@webrtc.org changed reviewers:
+ kwiberg@chromium.org
- tommi@webrtc.org

[tommi, 2015-11-19 16:06:06]

hmm, I'm out of cycles today at least.... Karl, can you review?

[the sun, 2015-11-19 16:08:06]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org
- kwiberg@chromium.org

[the sun, 2015-11-19 23:50:12]

On 2015/11/19 16:06:06, tommi (webrtc) wrote:
> hmm, I'm out of cycles today at least.... Karl, can you review?

Karl's out tomorrow so I'm bouncing it back to you in the hope that you find
some time...

[the sun, 2015-11-19 23:50:25]

solenberg@webrtc.org changed reviewers:
+ tommi@webrtc.org
- kwiberg@webrtc.org

[the sun, 2015-11-20 11:59:30]

solenberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[the sun, 2015-11-20 12:12:48]

On 2015/11/19 23:50:12, the sun wrote:
> On 2015/11/19 16:06:06, tommi (webrtc) wrote:
> > hmm, I'm out of cycles today at least.... Karl, can you review?
> 
> Karl's out tomorrow so I'm bouncing it back to you in the hope that you find
> some time...

Tommi, I assigned this to hlundin also, in case you're swamped.

[hlundin-webrtc, 2015-11-20 12:59:22]

LGTM with a few comments and nits.

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1558:
RemoveRecvStream(recv_streams_.begin()->first);
This is slightly backwards by design. Iterate through vector; for each element,
pick out the ssrc; send that ssrc to another function that looks up that same
element in the same vector again, ...
But since you didn't make anything worse, I'm fine with it.

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:2242: int send_channel =
GetSendChannelId(receiver_reports_ssrc_);
const, if you are inclined towards local consts.

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:2278: int channel =
it->second->channel();
const

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:290: // Ensure extension is set
properly on new channel.
channel -> stream

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream.cc (right):

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream.cc:100: bool registered =
rtp_header_parser_->RegisterRtpHeaderExtension(
Nothing to report to |rtp| in this case?

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_send_s...
File webrtc/audio/audio_send_stream.cc (left):

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_send_s...
webrtc/audio/audio_send_stream.cc:54: 
Undo this change and you'll keep this file from the CL.

[the sun, 2015-11-20 14:24:10]

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:1558:
RemoveRecvStream(recv_streams_.begin()->first);
On 2015/11/20 12:59:21, hlundin-webrtc wrote:
> This is slightly backwards by design. Iterate through vector; for each
element,
> pick out the ssrc; send that ssrc to another function that looks up that same
> element in the same vector again, ...
> But since you didn't make anything worse, I'm fine with it.

Thanks, we'll get to it, eventually...
Added TODO.

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:2242: int send_channel =
GetSendChannelId(receiver_reports_ssrc_);
On 2015/11/20 12:59:21, hlundin-webrtc wrote:
> const, if you are inclined towards local consts.

I am, and I've changed it in this function, but won't go through the whole file
just now. It definitely doesn't follow the pattern, at large...

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine.cc:2278: int channel =
it->second->channel();
On 2015/11/20 12:59:21, hlundin-webrtc wrote:
> const

Done.

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/1454073002/diff/60001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvoiceengine_unittest.cc:290: // Ensure extension is set
properly on new channel.
On 2015/11/20 12:59:21, hlundin-webrtc wrote:
> channel -> stream

Done.

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream.cc (right):

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream.cc:100: bool registered =
rtp_header_parser_->RegisterRtpHeaderExtension(
On 2015/11/20 12:59:22, hlundin-webrtc wrote:
> Nothing to report to |rtp| in this case?

Not yet; leaving TODO for Stefan.

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_send_s...
File webrtc/audio/audio_send_stream.cc (left):

https://codereview.webrtc.org/1454073002/diff/60001/webrtc/audio/audio_send_s...
webrtc/audio/audio_send_stream.cc:54: 
On 2015/11/20 12:59:22, hlundin-webrtc wrote:
> Undo this change and you'll keep this file from the CL.

Done.

[the sun, 2015-11-20 14:24:49]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-11-20 14:24:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1454073002/#ps80001 (title:
"reabse+comments")

[commit-bot: I haz the power, 2015-11-20 14:24:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454073002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454073002/80001

[commit-bot: I haz the power, 2015-11-20 16:18:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 16:18:58]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2015-11-20 17:55:32]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2015-11-20 17:55:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454073002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454073002/80001

[commit-bot: I haz the power, 2015-11-20 17:59:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-20 17:59:51]

Patchset 5 (id:??) landed as
https://crrev.com/7add0584390dcfb236165a6472ede6c2a94eaeed
Cr-Commit-Position: refs/heads/master@{#10731}