[rtp_rtcp] rtcp::Dlrr block moved into own file and got Parse function

webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8f48c70bd6ab5920015bee4c4a2626f63d3f5de3
--- /dev/null
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr_unittest.cc
@@ -0,0 +1,105 @@
+/*
+ *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/dlrr.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "webrtc/modules/rtp_rtcp/source/byte_io.h"

[åsapersson, 2015/12/15 12:20:55]

nit: new line

[danilchap, 2015/12/15 13:02:17]

Done.

+using webrtc::rtcp::Dlrr;
+
+namespace webrtc {
+namespace {
+
+const uint32_t kSsrc = 0x12345678;
+const uint32_t kLastRR = 0x23344556;
+const uint32_t kDelay = 0x33343536;
+const uint8_t kBlock[] = {0x05, 0x00, 0x00, 0x03, 0x12, 0x34, 0x56, 0x78,
+                          0x23, 0x34, 0x45, 0x56, 0x33, 0x34, 0x35, 0x36};
+const size_t kBlockLength = sizeof(kBlock);

[åsapersson, 2015/12/15 12:20:55]

kBlockSizeBytes (as in other tests)

[danilchap, 2015/12/15 13:02:17]

Done.

+
+TEST(RtcpPacketDlrrTest, Empty) {
+  Dlrr dlrr;
+
+  EXPECT_EQ(0u, dlrr.BlockLength());
+}
+
+TEST(RtcpPacketDlrrTest, Create) {
+  Dlrr dlrr;
+  EXPECT_TRUE(dlrr.WithDlrrItem(kSsrc, kLastRR, kDelay));
+
+  ASSERT_EQ(kBlockLength, dlrr.BlockLength());
+  uint8_t buffer[kBlockLength];
+
+  dlrr.Create(buffer);
+  EXPECT_EQ(0, memcmp(buffer, kBlock, kBlockLength));
+}
+
+TEST(RtcpPacketDlrrTest, Parse) {
+  Dlrr dlrr;
+  uint16_t block_length = ByteReader<uint16_t>::ReadBigEndian(&kBlock[2]);
+  EXPECT_TRUE(dlrr.Parse(kBlock, block_length));
+
+  EXPECT_EQ(1u, dlrr.sub_blocks().size());
+  const Dlrr::SubBlock& block = dlrr.sub_blocks().front();
+  EXPECT_EQ(kSsrc, block.ssrc);
+  EXPECT_EQ(kLastRR, block.last_rr);
+  EXPECT_EQ(kDelay, block.delay_since_last_rr);
+}
+
+TEST(RtcpPacketDlrrTest, ParseFailsOnBadSize) {
+  const size_t kBigBufferSize = 0x100;  // More than enough.
+  uint8_t buffer[kBigBufferSize];
+  buffer[0] = 5;  // BlockType.

[åsapersson, 2015/12/15 12:20:55]

Dlrr::kBlockType

[danilchap, 2015/12/15 13:02:17]

Done.

+  buffer[1] = 0;  // Reserved.
+  buffer[2] = 0;  // Most significant size byte.
+  for (uint8_t size = 3; size < 6; ++size) {
+    buffer[3] = size;
+    Dlrr dlrr;
+    // Parse should be succesful only when size is multiple of 3.

[åsapersson, 2015/12/15 12:20:55]

s/succesful/successful

[danilchap, 2015/12/15 13:02:17]

Done.

+    EXPECT_EQ(size % 3 == 0, dlrr.Parse(buffer, (uint16_t)size));

[åsapersson, 2015/12/15 12:20:55]

static_cast<uint16_t>

[danilchap, 2015/12/15 13:02:17]

Done.

+  }
+}
+
+TEST(RtcpPacketDlrrTest, FailsOnTooManySubBlocks) {
+  Dlrr dlrr;
+  const size_t kSubBlockLimit = 100;

[åsapersson, 2015/12/15 12:20:55]

Dlrr::kMaxNumberOfDlrrItems

[danilchap, 2015/12/15 13:02:17]

Done.

+  for (size_t i = 1; i <= kSubBlockLimit; ++i) {
+    EXPECT_TRUE(dlrr.WithDlrrItem(kSsrc + i, kLastRR + i, kDelay + i));
+  }
+  EXPECT_FALSE(dlrr.WithDlrrItem(kSsrc, kLastRR, kDelay));
+}
+
+TEST(RtcpPacketDlrrTest, CreateAndParseMaxSize) {

[åsapersson, 2015/12/15 12:20:55]

maybe CreateAndParseMaxSubBlocks

[danilchap, 2015/12/15 13:02:17]

Done.

+  const size_t kSubBlockLimit = 100;

[åsapersson, 2015/12/15 12:20:55]

Dlrr::kMaxNumberOfDlrrItems

[danilchap, 2015/12/15 13:02:17]

Done.

+  const size_t kBufferSize = 0x1000;  // More than enough.
+  uint8_t buffer[kBufferSize];
+  size_t used_buffer_size = 0;
+  {  // Create.
+    Dlrr dlrr;
+    for (size_t i = 1; i <= kSubBlockLimit; ++i) {
+      EXPECT_TRUE(dlrr.WithDlrrItem(kSsrc + i, kLastRR + i, kDelay + i));
+    }
+    used_buffer_size = dlrr.BlockLength();
+    ASSERT_LE(used_buffer_size, kBufferSize);
+    dlrr.Create(buffer);
+  }

[åsapersson, 2015/12/15 12:20:55]

{} needed? and below

[danilchap, 2015/12/15 13:02:17]

used to show that Create and Parse parts use only buffer to talk to each other.
Guess it complicates test more than it clarifies it. Removed.

+
+  {  // Parse.
+    Dlrr parsed;
+    uint16_t block_length = ByteReader<uint16_t>::ReadBigEndian(&buffer[2]);
+    EXPECT_EQ(used_buffer_size, (block_length + 1) * 4u);
+    EXPECT_TRUE(parsed.Parse(buffer, block_length));
+    EXPECT_EQ(kSubBlockLimit, parsed.sub_blocks().size());
+  }
+}
+
+}  // namespace
+}  // namespace webrtc