Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1453693002: Set temporal up switch bit to false for flexible mode (one temporal layer is configured currently). (Closed)

Created:
5 years, 1 month ago by åsapersson
Modified:
5 years, 1 month ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set temporal up switch bit to false for flexible mode (one temporal layer is configured currently). BUG=webrtc:5214 Committed: https://crrev.com/cb50c96be28082ed8b819445799ee49c0c2de2d6 Cr-Commit-Position: refs/heads/master@{#10685}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 11 (4 generated)
åsapersson
5 years, 1 month ago (2015-11-17 12:38:40 UTC) #4
stefan-webrtc
lgtm https://codereview.webrtc.org/1453693002/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1453693002/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode588 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:588: vp9_info->temporal_up_switch = false; I assume it's still a ...
5 years, 1 month ago (2015-11-17 23:49:04 UTC) #5
philipel
On 2015/11/17 23:49:04, stefan-webrtc (holmer) wrote: > lgtm > > https://codereview.webrtc.org/1453693002/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc > File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): ...
5 years, 1 month ago (2015-11-18 09:25:53 UTC) #6
åsapersson
https://codereview.webrtc.org/1453693002/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/1453693002/diff/1/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc#newcode588 webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:588: vp9_info->temporal_up_switch = false; On 2015/11/17 23:49:04, stefan-webrtc (holmer) wrote: ...
5 years, 1 month ago (2015-11-18 09:52:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453693002/1
5 years, 1 month ago (2015-11-18 09:54:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 09:58:59 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 09:59:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb50c96be28082ed8b819445799ee49c0c2de2d6
Cr-Commit-Position: refs/heads/master@{#10685}

Powered by Google App Engine
This is Rietveld 408576698