rtcp::ReceiverReport moved into own file and got Parse function

rtcp::ReceiverReport moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed: https://crrev.com/97f7e13c23ddb26543f33bce944d501e58d1dd9b
Cr-Commit-Position: refs/heads/master@{#10897}

[danilchap, 2015-11-17 11:13:45]

Description was changed from

==========
rtcp::ReciverReport moved into own file and got Parse function
==========

to

==========
rtcp::ReceiverReport moved into own file and got Parse function
==========

[danilchap, 2015-11-17 11:13:46]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org, sprang@webrtc.org

[åsapersson, 2015-12-03 13:56:42]

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h (right):

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h:51: static const
int kMaxNumberOfReportBlocks = 0x1F;
size_t?

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc
(right):

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:13:
#include <limits>
needed?

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:55: //
Manually created ReciverReport with one ReportBlock matching constants above.
s/ReciverReport/ReceiverReport

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:56: //
Having this block allows to test Create and Parse seperately.
s/seperately/separately

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:61: const
size_t kPacketLength = sizeof(kPacket);
perhaps move the constants above the class

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:63:
TEST_F(RtcpPacketReceiverReportTest, NoBlocks) {
maybe WithNoReportBlock (and move below Create).

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:91:
TEST_F(RtcpPacketReceiverReportTest, ParseFailesOnIncorretSize) {
s/Failes/Fails
s/Incorret/Incorrect

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:95:
EXPECT_FALSE(rr.Parse(header, kPacket + kPacketLength));
kPacket + RtcpCommonHeader::kHeaderSizeBytes?

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc (right):

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc:33: using
webrtc::rtcp::Remb;
alphabetic order

[danilchap, 2015-12-03 14:23:16]

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h (right):

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h:51: static const
int kMaxNumberOfReportBlocks = 0x1F;
On 2015/12/03 13:56:41, åsapersson wrote:
> size_t?

Done.

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc
(right):

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:13:
#include <limits>
On 2015/12/03 13:56:42, åsapersson wrote:
> needed?

Done.

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:55: //
Manually created ReciverReport with one ReportBlock matching constants above.
On 2015/12/03 13:56:41, åsapersson wrote:
> s/ReciverReport/ReceiverReport

Done.

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:56: //
Having this block allows to test Create and Parse seperately.
On 2015/12/03 13:56:42, åsapersson wrote:
> s/seperately/separately

Done.

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:61: const
size_t kPacketLength = sizeof(kPacket);
On 2015/12/03 13:56:42, åsapersson wrote:
> perhaps move the constants above the class

Done.

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:63:
TEST_F(RtcpPacketReceiverReportTest, NoBlocks) {
On 2015/12/03 13:56:41, åsapersson wrote:
> maybe WithNoReportBlock (and move below Create).

Done. WithNo = Without

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:91:
TEST_F(RtcpPacketReceiverReportTest, ParseFailesOnIncorretSize) {
On 2015/12/03 13:56:41, åsapersson wrote:
> s/Failes/Fails
> s/Incorret/Incorrect

Done.

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc:95:
EXPECT_FALSE(rr.Parse(header, kPacket + kPacketLength));
On 2015/12/03 13:56:41, åsapersson wrote:
> kPacket + RtcpCommonHeader::kHeaderSizeBytes?

Done.

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc (right):

https://codereview.webrtc.org/1453083002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc:33: using
webrtc::rtcp::Remb;
On 2015/12/03 13:56:42, åsapersson wrote:
> alphabetic order

Done.

[danilchap, 2015-12-03 14:23:50]

Description was changed from

==========
rtcp::ReceiverReport moved into own file and got Parse function
==========

to

==========
rtcp::ReceiverReport moved into own file and got Parse function

BUG=webrtc:5260
==========

[åsapersson, 2015-12-03 14:38:59]

lgtm

[danilchap, 2015-12-03 17:31:41]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-12-03 17:31:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1453083002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-12-03 17:32:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1453083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1453083002/40001

[commit-bot: I haz the power, 2015-12-03 17:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 17:34:37]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2146)

[danilchap, 2015-12-04 15:13:44]

Description was changed from

==========
rtcp::ReceiverReport moved into own file and got Parse function

BUG=webrtc:5260
==========

to

==========
rtcp::ReceiverReport moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/97f7e13c23ddb26543f33bce9...
==========

[danilchap, 2015-12-04 15:13:46]

Committed patchset #4 (id:60001) manually as
97f7e13c23ddb26543f33bce944d501e58d1dd9b (presubmit successful).

[commit-bot: I haz the power, 2015-12-04 15:13:48]

Description was changed from

==========
rtcp::ReceiverReport moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/97f7e13c23ddb26543f33bce9...
==========

to

==========
rtcp::ReceiverReport moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed: https://crrev.com/97f7e13c23ddb26543f33bce944d501e58d1dd9b
Cr-Commit-Position: refs/heads/master@{#10897}
==========

[commit-bot: I haz the power, 2015-12-04 15:13:48]

Patchset 4 (id:??) landed as
https://crrev.com/97f7e13c23ddb26543f33bce944d501e58d1dd9b
Cr-Commit-Position: refs/heads/master@{#10897}