talk/media/webrtc/webrtcvideoengine2.h - Issue 1452883002: Require negotiation to send transport cc feedback over RTCP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvideoengine2.h

Issue 1452883002: Require negotiation to send transport cc feedback over RTCP. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: . Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/media/webrtc/webrtcvideoengine2.h

diff --git a/talk/media/webrtc/webrtcvideoengine2.h b/talk/media/webrtc/webrtcvideoengine2.h

index 05f73d13581964245c9faa0dddc0545bdca9f243..d5738bbe587613eac0d9ac98f70e77c5c72a593f 100644

--- a/talk/media/webrtc/webrtcvideoengine2.h

+++ b/talk/media/webrtc/webrtcvideoengine2.h

@@ -401,7 +401,9 @@ class WebRtcVideoChannel2 : public rtc::MessageHandler,

const std::vector<uint32_t>& GetSsrcs() const;

void SetLocalSsrc(uint32_t local_ssrc);

- void SetNackAndRemb(bool nack_enabled, bool remb_enabled);

+ void SetFeedbackOptions(bool nack_enabled,

+ bool remb_enabled,

+ bool transport_cc_enabled);

pthatcher 2015/11/19 00:19:20 Why not SetFeedbackParameters or SetFeedbackParams

stefan-webrtc 2015/11/20 16:58:48 Done.

void SetRecvCodecs(const std::vector<VideoCodecSettings>& recv_codecs);

void SetRtpExtensions(const std::vector<webrtc::RtpExtension>& extensions);

« talk/media/base/constants.cc ('K') | « talk/media/base/constants.cc ('k') | talk/media/webrtc/webrtcvideoengine2.cc » ('j') | talk/media/webrtc/webrtcvideoengine2.cc » ('J')