Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: talk/media/base/codec.cc

Issue 1452883002: Require negotiation to send transport cc feedback over RTCP. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 bool HasNack(const VideoCodec& codec) { 327 bool HasNack(const VideoCodec& codec) {
328 return codec.HasFeedbackParam( 328 return codec.HasFeedbackParam(
329 FeedbackParam(kRtcpFbParamNack, kParamValueEmpty)); 329 FeedbackParam(kRtcpFbParamNack, kParamValueEmpty));
330 } 330 }
331 331
332 bool HasRemb(const VideoCodec& codec) { 332 bool HasRemb(const VideoCodec& codec) {
333 return codec.HasFeedbackParam( 333 return codec.HasFeedbackParam(
334 FeedbackParam(kRtcpFbParamRemb, kParamValueEmpty)); 334 FeedbackParam(kRtcpFbParamRemb, kParamValueEmpty));
335 } 335 }
336 336
337 bool HasTransportCcFeedback(const VideoCodec& codec) {
pthatcher 2015/11/19 00:19:20 I think just HasTransportCc would be sufficient an
stefan-webrtc 2015/11/20 16:58:48 Done.
338 return codec.HasFeedbackParam(
339 FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty));
340 }
341
337 bool CodecNamesEq(const std::string& name1, const std::string& name2) { 342 bool CodecNamesEq(const std::string& name1, const std::string& name2) {
338 return _stricmp(name1.c_str(), name2.c_str()) == 0; 343 return _stricmp(name1.c_str(), name2.c_str()) == 0;
339 } 344 }
340 345
341 } // namespace cricket 346 } // namespace cricket
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698