rtcp::VoipMetric block moved into own file and got Parse function

rtcp::VoipMetric block moved into own file and got Parse function

Committed: https://crrev.com/91941ae493cb37a4e1250c7d3aad1c7394b5850e
Cr-Commit-Position: refs/heads/master@{#11030}

[danilchap, 2015-11-16 19:10:22]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org, sprang@webrtc.org

[åsapersson, 2015-12-14 10:53:45]

lgtm with minor comments addressed

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/r...
File webrtc/modules/rtp_rtcp/rtp_rtcp.gypi (right):

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/r...
webrtc/modules/rtp_rtcp/rtp_rtcp.gypi:50: 'source/rtcp_packet/voip_metric.h',
alphabetic order

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric.cc (right):

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric.cc:42:
memset(&voip_metric_, 0, sizeof(voip_metric_));
is memset needed?

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc (right):

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc:25: const
size_t kBlockLength = sizeof(kBlock);
maybe kBlockSizeBytes to not mix-up with kBlockLength in voip_metric.h

[danilchap, 2015-12-14 12:21:31]

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/r...
File webrtc/modules/rtp_rtcp/rtp_rtcp.gypi (right):

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/r...
webrtc/modules/rtp_rtcp/rtp_rtcp.gypi:50: 'source/rtcp_packet/voip_metric.h',
On 2015/12/14 10:53:45, åsapersson wrote:
> alphabetic order

Done.

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric.cc (right):

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric.cc:42:
memset(&voip_metric_, 0, sizeof(voip_metric_));
On 2015/12/14 10:53:45, åsapersson wrote:
> is memset needed?
struct RTCPVoIPMetric (voip_metric_) doesn't have a constructor that would
initialize values.
Leaving structure uninitialized feels to me like a bad practice,
so initializing all fields of RTCPVoIPMetric to 0 with memset.

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc (right):

https://codereview.webrtc.org/1452733002/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/voip_metric_unittest.cc:25: const
size_t kBlockLength = sizeof(kBlock);
On 2015/12/14 10:53:45, åsapersson wrote:
> maybe kBlockSizeBytes to not mix-up with kBlockLength in voip_metric.h

Done.

[danilchap, 2015-12-15 14:51:54]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-12-15 14:51:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1452733002/#ps120001 (title:
"rebase")

[commit-bot: I haz the power, 2015-12-15 14:52:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1452733002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1452733002/120001

[commit-bot: I haz the power, 2015-12-15 15:06:40]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-12-15 15:06:49]

Description was changed from

==========
rtcp::VoipMetric block moved into own file and got Parse function
==========

to

==========
rtcp::VoipMetric block moved into own file and got Parse function

Committed: https://crrev.com/91941ae493cb37a4e1250c7d3aad1c7394b5850e
Cr-Commit-Position: refs/heads/master@{#11030}
==========

[commit-bot: I haz the power, 2015-12-15 15:06:50]

Patchset 7 (id:??) landed as
https://crrev.com/91941ae493cb37a4e1250c7d3aad1c7394b5850e
Cr-Commit-Position: refs/heads/master@{#11030}