Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1452153003: Remove dead code (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@rac6
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dead code Committed: https://crrev.com/223692aa857192ed1764737ecae086523dc03f84 Cr-Commit-Position: refs/heads/master@{#10692}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -128 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_manager.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 1 6 chunks +37 lines, -123 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kwiberg-webrtc
5 years, 1 month ago (2015-11-18 09:41:28 UTC) #2
hlundin-webrtc
LGTM with nit. https://codereview.webrtc.org/1452153003/diff/1/webrtc/modules/audio_coding/main/acm2/codec_manager.cc File webrtc/modules/audio_coding/main/acm2/codec_manager.cc (right): https://codereview.webrtc.org/1452153003/diff/1/webrtc/modules/audio_coding/main/acm2/codec_manager.cc#newcode29 webrtc/modules/audio_coding/main/acm2/codec_manager.cc:29: "supported) for primary encoder", We no ...
5 years, 1 month ago (2015-11-18 10:20:57 UTC) #3
kwiberg-webrtc
https://codereview.webrtc.org/1452153003/diff/1/webrtc/modules/audio_coding/main/acm2/codec_manager.cc File webrtc/modules/audio_coding/main/acm2/codec_manager.cc (right): https://codereview.webrtc.org/1452153003/diff/1/webrtc/modules/audio_coding/main/acm2/codec_manager.cc#newcode29 webrtc/modules/audio_coding/main/acm2/codec_manager.cc:29: "supported) for primary encoder", On 2015/11/18 10:20:57, hlundin-webrtc wrote: ...
5 years, 1 month ago (2015-11-18 15:38:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452153003/20001
5 years, 1 month ago (2015-11-18 15:38:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 16:27:55 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 16:28:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/223692aa857192ed1764737ecae086523dc03f84
Cr-Commit-Position: refs/heads/master@{#10692}

Powered by Google App Engine
This is Rietveld 408576698