Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1451663002: Unconditionally build VP9 support. (Closed)

Created:
5 years, 1 month ago by pbos-webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Unconditionally build VP9 support. Broken for PeerConnection either way (since VP9 support is announced) and would fail on a CHECK apart from generating incorrect offers/answers. This isn't a flag that we want to support, so it's better to remove the foot-shooting gun. BUG= R=asapersson@webrtc.org, kjellander@webrtc.org, phoglund@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/bd05f0ba52be050d7b438d5e191b8976506018d2 Cr-Commit-Position: refs/heads/master@{#10676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -56 lines) Patch
M webrtc/build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +9 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9.gyp View 1 chunk +14 lines, -20 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp9/vp9_dummy_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pbos-webrtc
PTAL, woo
5 years, 1 month ago (2015-11-16 13:42:16 UTC) #3
kjellander_webrtc
lgtm
5 years, 1 month ago (2015-11-16 13:56:43 UTC) #4
åsapersson
lgtm
5 years, 1 month ago (2015-11-16 14:04:36 UTC) #5
phoglund
lgtm
5 years, 1 month ago (2015-11-17 14:21:22 UTC) #6
stefan-webrtc
lgtm
5 years, 1 month ago (2015-11-17 14:26:21 UTC) #9
pbos-webrtc
Committed patchset #1 (id:1) manually as bd05f0ba52be050d7b438d5e191b8976506018d2 (presubmit successful).
5 years, 1 month ago (2015-11-17 14:27:45 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 14:27:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd05f0ba52be050d7b438d5e191b8976506018d2
Cr-Commit-Position: refs/heads/master@{#10676}

Powered by Google App Engine
This is Rietveld 408576698