Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1450203002: Revert of Several Tick counter improvements. (Closed)

Created:
5 years, 1 month ago by thaloun
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Andrew MacDonald, peah-webrtc, mflodman, henrika_webrtc, noahric
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Several Tick counter improvements. (patchset #8 id:140001 of https://codereview.webrtc.org/1415923010/ ) Reason for revert: Potentially breaks a threading test under DrMemory. Rolling back while I investigate. Original issue's description: > Several Tick counter improvements. > > Move logic into cc file > Simplify interval calculation > Remove unused QUERY_PERFORMANCE_COUNTER windows implementation > Remove double divide on each ::Now() invocation on mac > > Move TickTime and TickInterval funcitons to cc file in prep for refactoring. > > BUG= > R=mflodman@webrtc.org, pbos@webrtc.org > > Committed: https://crrev.com/4c27e4b62da2047063d88eedfeec3e939fea7843 > Cr-Commit-Position: refs/heads/master@{#10661} TBR=pbos@webrtc.org,mflodman@webrtc.org,noahric@chromium.org,thaloun@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c91d1738709b038fee84d569180cba2bbcbfe5d7 Cr-Commit-Position: refs/heads/master@{#10663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -98 lines) Patch
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/tick_util.h View 4 chunks +104 lines, -10 lines 0 comments Download
M webrtc/system_wrappers/source/tick_util.cc View 4 chunks +35 lines, -85 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
thaloun
Created Revert of Several Tick counter improvements.
5 years, 1 month ago (2015-11-17 00:27:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450203002/1
5 years, 1 month ago (2015-11-17 00:27:17 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-17 00:27:18 UTC) #4
noahric
lgtm
5 years, 1 month ago (2015-11-17 00:28:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450203002/1
5 years, 1 month ago (2015-11-17 00:28:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 00:28:54 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c91d1738709b038fee84d569180cba2bbcbfe5d7 Cr-Commit-Position: refs/heads/master@{#10663}
5 years, 1 month ago (2015-11-17 00:29:06 UTC) #9
pbos-webrtc
5 years, 1 month ago (2015-11-17 10:59:03 UTC) #10
Message was sent while issue was closed.
On 2015/11/17 00:29:06, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c91d1738709b038fee84d569180cba2bbcbfe5d7
> Cr-Commit-Position: refs/heads/master@{#10663}

Already tracked here: https://bugs.chromium.org/p/webrtc/issues/detail?id=5199

Please re-land. :)

Powered by Google App Engine
This is Rietveld 408576698